Re: [PATCH 1 of 2] extdiff: support tools that can be run simultaneously

2019-02-04 Thread Ludovic Chabant
> > Oh right, that's another thing I wanted to ask -- how would I test that? > > The only idea I have is to log some verbose message ("tool %s has a > > graphical interface, launching processes simultaneously") and detect that > > in test. Is there any better way? > > Something like that.

Re: [PATCH 1 of 2] extdiff: support tools that can be run simultaneously

2019-02-04 Thread Yuya Nishihara
On Sun, 03 Feb 2019 08:52:47 -0800, Ludovic Chabant wrote: > > Generally looks good. Can you add some tests? > > Oh right, that's another thing I wanted to ask -- how would I test that? The > only idea I have is to log some verbose message ("tool %s has a graphical > interface, launching

Re: [PATCH 1 of 2] extdiff: support tools that can be run simultaneously

2019-02-03 Thread Ludovic Chabant
> Generally looks good. Can you add some tests? Oh right, that's another thing I wanted to ask -- how would I test that? The only idea I have is to log some verbose message ("tool %s has a graphical interface, launching processes simultaneously") and detect that in test. Is there any better

Re: [PATCH 1 of 2] extdiff: support tools that can be run simultaneously

2019-02-03 Thread Yuya Nishihara
On Sat, 02 Feb 2019 22:24:34 -0800, Ludovic Chabant wrote: > # HG changeset patch > # User Ludovic Chabant > # Date 1549173529 28800 > # Sat Feb 02 21:58:49 2019 -0800 > # Node ID b08ea934c2d5ac097b171ca74e826e4f9dea86a9 > # Parent 3a3b053d0882a33ba7ea667052e445b193ffa4df > extdiff: support

Re: [PATCH 1 of 2] extdiff: support tools that can be run simultaneously

2019-02-03 Thread Yuya Nishihara
On Sat, 02 Feb 2019 22:43:59 -0800, Ludovic Chabant wrote: > One thing I'm not quite sure about this change is how to handle the new "gui" > config flag. > > I wanted to use (abuse?) the difference between False and None in order to > figure out if we found the flag in a section or not (and

Re: [PATCH 1 of 2] extdiff: support tools that can be run simultaneously

2019-02-02 Thread Ludovic Chabant
One thing I'm not quite sure about this change is how to handle the new "gui" config flag. I wanted to use (abuse?) the difference between False and None in order to figure out if we found the flag in a section or not (and fall back to another section if not). However, passing None as the

[PATCH 1 of 2] extdiff: support tools that can be run simultaneously

2019-02-02 Thread Ludovic Chabant
# HG changeset patch # User Ludovic Chabant # Date 1549173529 28800 # Sat Feb 02 21:58:49 2019 -0800 # Node ID b08ea934c2d5ac097b171ca74e826e4f9dea86a9 # Parent 3a3b053d0882a33ba7ea667052e445b193ffa4df extdiff: support tools that can be run simultaneously diff --git a/hgext/extdiff.py