Re: [PATCH 8 of 8] perf: replace ui.configint() by getint() for Mercurial earlier than 1.9

2016-08-11 Thread timeless
> I expect check-code.py to detect this kind of problem, but now I > notice that it checks only gratuitous whitespace "after" =. Maybe, for > some column positioning like as below ? Yeah, that's the reason it doesn't. It's probably possible to try to detect blocks that are trying to align, but

Re: [PATCH 8 of 8] perf: replace ui.configint() by getint() for Mercurial earlier than 1.9

2016-08-11 Thread FUJIWARA Katsunori
At Thu, 11 Aug 2016 02:43:33 -0400, timeless wrote: > > FUJIWARA Katsunori wrote: > > +v = ui.config(section, name, None) > > fwiw, you have two spaces before `=` > Thank you for pointing out! I expect check-code.py to detect this kind of problem, but now I notice that it checks only