Re: [PATCH V2] localrepo: avoid unnecessary conversion from node to rev

2017-02-11 Thread Gregory Szorc
> On Feb 10, 2017, at 05:48, Yuya Nishihara wrote: > >> On Tue, 7 Feb 2017 13:11:23 -0800, Jun Wu wrote: >> V1 was accepted and in hg-committed [1] already. I don't know the official >> recommended workflows but I used to just push follow-up fixes. > > It's at the bottom of the draft stack, so

Re: [PATCH V2] localrepo: avoid unnecessary conversion from node to rev

2017-02-10 Thread Augie Fackler
On Fri, Feb 10, 2017 at 10:48:10PM +0900, Yuya Nishihara wrote: > On Tue, 7 Feb 2017 13:11:23 -0800, Jun Wu wrote: > > V1 was accepted and in hg-committed [1] already. I don't know the official > > recommended workflows but I used to just push follow-up fixes. > > It's at the bottom of the draft st

Re: [PATCH V2] localrepo: avoid unnecessary conversion from node to rev

2017-02-10 Thread Yuya Nishihara
On Tue, 7 Feb 2017 13:11:23 -0800, Jun Wu wrote: > V1 was accepted and in hg-committed [1] already. I don't know the official > recommended workflows but I used to just push follow-up fixes. It's at the bottom of the draft stack, so I think follow-ups would be preferred. > Excerpts from Stanislau

Re: [PATCH V2] localrepo: avoid unnecessary conversion from node to rev

2017-02-07 Thread Jun Wu
V1 was accepted and in hg-committed [1] already. I don't know the official recommended workflows but I used to just push follow-up fixes. In general, it's a good practice to use hg-committed instead of the hg repo for development, to avoid potential conflicts with other changes. [1]: https://www.

[PATCH V2] localrepo: avoid unnecessary conversion from node to rev

2017-02-07 Thread Stanislau Hlebik
# HG changeset patch # User Stanislau Hlebik # Date 1486457478 28800 # Tue Feb 07 00:51:18 2017 -0800 # Node ID 8614d5d15d6fe47c3bcfdf79823f68f18c7741ae # Parent 1f51b4658f21bbb797e922d155c1046eddccf91d localrepo: avoid unnecessary conversion from node to rev changelog.heads() first calls h