This revision was automatically updated to reflect the committed changes.
Closed by commit rHGbd177139e635: mpatch: reformat function prototypes with
clang-format (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 updated this revision to Diff 2823.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1028?vs=2628=2823
REVISION DETAIL
https://phab.mercurial-scm.org/D1028
AFFECTED FILES
mercurial/mpatch.c
mercurial/mpatch.h
CHANGE DETAILS
diff --git
durin42 added a comment.
In https://phab.mercurial-scm.org/D1028#17622, @ryanmce wrote:
> I, for one, am -1 on tabs but that's not a battle worth fighting probably.
However, we can probably come up with a smarter test-check-code. If we're
moving towards clang-format, it seems that the
durin42 added a comment.
In https://phab.mercurial-scm.org/D1028#17513, @yuja wrote:
> Seemed fine, but test-check-code.t says no.
>
> + mercurial/mpatch.c:268:
> + > ssize_t start, ssize_t end)
> + don't use spaces to indent
> + mercurial/mpatch.h:24:
ryanmce added a comment.
I thought it was string that check-code doesn't fire on
https://phab.mercurial-scm.org/D1030 but does fire here.
It turns out that the check-code only finds spaces at the start of the line.
So is you start with a tab and then spaces, that's fine. But if you
yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.
Seemed fine, but test-check-code.t says no.
+ mercurial/mpatch.c:268:
+ > ssize_t start, ssize_t end)
+ don't use spaces to indent
+
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1028
AFFECTED FILES
mercurial/mpatch.c
mercurial/mpatch.h
CHANGE DETAILS
diff --git
