Re: D110: sparse: add a requirement when a repository uses sparse (BC)

2017-07-18 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9b2647a7a70a: sparse: add a requirement when a repository uses sparse (BC) (authored by indygreg). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D110?vs=216=277

Re: D110: sparse: add a requirement when a repository uses sparse (BC)

2017-07-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > indygreg wrote in sparse.py:526 > Yes, it would be cleaner to have a dedicated function to turn off sparse. > Yes, it would unlink .hg/sparse. I was being a bit lazy when I wrote this > patch because I wanted to get something in before the

Re: D110: sparse: add a requirement when a repository uses sparse (BC)

2017-07-17 Thread indygreg (Gregory Szorc)
indygreg added inline comments. INLINE COMMENTS > martinvonz wrote in sparse.py:526 > It feels like this would be clearer as two method: the old one and a new one > that just turns sparse off. That would ideally unlink .hg/sparse, no? The new > method would not accept includes, excludes, or

Re: D110: sparse: add a requirement when a repository uses sparse (BC)

2017-07-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > sparse.py:526 > def _updateconfigandrefreshwdir(repo, includes, excludes, profiles, > -force=False): > +force=False, removing=False): > """Update the sparse config and

Re: D110: sparse: add a requirement when a repository uses sparse (BC)

2017-07-17 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The presence of a sparse checkout can confuse legacy clients or clients without sparse enabled for reasons that should be obvious. This commit introduces a