This revision was automatically updated to reflect the committed changes.
Closed by commit rHGffeea2406276: dirstate: remove excess attribute lookups for
dirstate.status (issue5714) (authored by durham, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
yuja accepted this revision.
yuja added a comment.
This revision is now accepted and ready to land.
Queued, thanks.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1257
To: durham, #hg-reviewers, yuja
Cc: mercurial-devel
durham added a comment.
Fixed by using _map.clear() instead of replacing the _map.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1257
To: durham, #hg-reviewers, yuja
Cc: mercurial-devel
___
Mercurial-devel mailing
durham updated this revision to Diff 3147.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1257?vs=3136=3147
REVISION DETAIL
https://phab.mercurial-scm.org/D1257
AFFECTED FILES
mercurial/dirstate.py
CHANGE DETAILS
diff --git a/mercurial/dirstate.py
yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.
Probably the cached attributes need to be deleted at clear(), where new
dict is assigned to self._map.
REPOSITORY
rHG Mercurial
REVISION DETAIL
durham created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
A recent refactor added a layer of abstraction to the dirstate which makes
doing
things like 'foo in dirstate' now require some extra Python attribute lookups.
