lothiraldan added a comment.
In https://phab.mercurial-scm.org/D1694#79416, @pulkit wrote:
> In https://phab.mercurial-scm.org/D1694#29072, @yuja wrote:
>
> > Sometimes we do the reverse change for ease of calling command function
as a plain function.
>
>
> Just for record,
pulkit added a comment.
In https://phab.mercurial-scm.org/D1694#29072, @yuja wrote:
> Sometimes we do the reverse change for ease of calling command function
as a plain function.
Just for record, today I hit the problem where some command is using
`opts['']` instead of
pulkit added a comment.
@martinvonz do you want to pursue this or can this be mark as abandoned?
(Trying to close differentials which are no longer required)
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1694
To: martinvonz, #hg-reviewers
Cc: pulkit, durin42,
durin42 added a comment.
I don't feel strongly either. Martin, if you want to pursue this (which seems
fine to me) why not make ocmmands.py consistent as well?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1694
To: martinvonz, #hg-reviewers
Cc: durin42, yuja,
yuja added a comment.
In https://phab.mercurial-scm.org/D1694#31044, @durin42 wrote:
> I think it's probably okay for debug commands, those are pretty rare to use
as a function aren't they?
Yeah, it's okay, but why do we apply a different rule to debug commands?
If we take
durin42 added a comment.
In https://phab.mercurial-scm.org/D1694#29072, @yuja wrote:
> Queued the first three patches, but I'm not certain about this. Sometimes we
> do the reverse change for ease of calling command function as a plain
function.
I think it's probably okay for
yuja added a comment.
Queued the first three patches, but I'm not certain about this. Sometimes we
do the reverse change for ease of calling command function as a plain
function.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1694
To: martinvonz,
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1694
AFFECTED FILES
mercurial/debugcommands.py
CHANGE DETAILS
diff --git