D1694: debugcommands: replace opts.get('foo') by opts['foo']

2018-12-01 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. In https://phab.mercurial-scm.org/D1694#79416, @pulkit wrote: > In https://phab.mercurial-scm.org/D1694#29072, @yuja wrote: > > > Sometimes we do the reverse change for ease of calling command function as a plain function. > > > Just for record,

D1694: debugcommands: replace opts.get('foo') by opts['foo']

2018-11-30 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D1694#29072, @yuja wrote: > Sometimes we do the reverse change for ease of calling command function as a plain function. Just for record, today I hit the problem where some command is using `opts['']` instead of

D1694: debugcommands: replace opts.get('foo') by opts['foo']

2018-06-14 Thread pulkit (Pulkit Goyal)
pulkit added a comment. @martinvonz do you want to pursue this or can this be mark as abandoned? (Trying to close differentials which are no longer required) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1694 To: martinvonz, #hg-reviewers Cc: pulkit, durin42,

D1694: debugcommands: replace opts.get('foo') by opts['foo']

2018-01-18 Thread durin42 (Augie Fackler)
durin42 added a comment. I don't feel strongly either. Martin, if you want to pursue this (which seems fine to me) why not make ocmmands.py consistent as well? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1694 To: martinvonz, #hg-reviewers Cc: durin42, yuja,

D1694: debugcommands: replace opts.get('foo') by opts['foo']

2018-01-12 Thread yuja (Yuya Nishihara)
yuja added a comment. In https://phab.mercurial-scm.org/D1694#31044, @durin42 wrote: > I think it's probably okay for debug commands, those are pretty rare to use as a function aren't they? Yeah, it's okay, but why do we apply a different rule to debug commands? If we take

D1694: debugcommands: replace opts.get('foo') by opts['foo']

2018-01-10 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D1694#29072, @yuja wrote: > Queued the first three patches, but I'm not certain about this. Sometimes we > do the reverse change for ease of calling command function as a plain function. I think it's probably okay for

D1694: debugcommands: replace opts.get('foo') by opts['foo']

2017-12-15 Thread yuja (Yuya Nishihara)
yuja added a comment. Queued the first three patches, but I'm not certain about this. Sometimes we do the reverse change for ease of calling command function as a plain function. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1694 To: martinvonz,

D1694: debugcommands: replace opts.get('foo') by opts['foo']

2017-12-14 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1694 AFFECTED FILES mercurial/debugcommands.py CHANGE DETAILS diff --git