This revision was automatically updated to reflect the committed changes.
Closed by commit rHG62a428bf6359: logexchange: introduce helper function to get
remote path name (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
pulkit added a comment.
I will like to get this series review and iterated upon early in cycle so
that we can ship remotenames in the next release.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1755
To: pulkit, #hg-reviewers, durin42
Cc: durin42,
pulkit updated this revision to Diff 5144.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1755?vs=4794=5144
REVISION DETAIL
https://phab.mercurial-scm.org/D1755
AFFECTED FILES
mercurial/logexchange.py
tests/test-logexchange.t
CHANGE DETAILS
diff
durin42 added inline comments.
INLINE COMMENTS
> logexchange.py:102
> +local = remote.local()
> +except AttributeError:
> +pass
what's the deal with this attributeerror business? merits a comment at least
> logexchange.py:113
> +rpath = remote._url
> +
pulkit updated this revision to Diff 4794.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1755?vs=4605=4794
REVISION DETAIL
https://phab.mercurial-scm.org/D1755
AFFECTED FILES
mercurial/logexchange.py
tests/test-logexchange.t
CHANGE DETAILS
diff
durin42 requested changes to this revision.
durin42 added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> logexchange.py:109
> +if local:
> +rpath = getattr(remote, 'root', None)
> +if rpath is None:
This should be cleaned up to not have all
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This patch moves chunk of activepath function from hgremotenames extension
(linktoremotenameextension) to core. Before moving rest of the part, there
needs
to
