yuja added inline comments.
INLINE COMMENTS
> pulkit wrote in verify.py:110
> Looks like we cannot use "%d" here as None can be possible value also and
> test-treemanifest.t has tests with None as a part of output.
Ugh, it smells, but let's just leave it for now.
REPOSITORY
rHG Mercurial
pulkit added inline comments.
INLINE COMMENTS
> yuja wrote in verify.py:110
> '%d', perhaps.
Looks like we cannot use "%d" here as None can be possible value also and
test-treemanifest.t has tests with None as a part of output.
REPOSITORY
rHG Mercurial
REVISION DETAIL
yuja added inline comments.
INLINE COMMENTS
> subrepo.py:392
> if source.isabs():
> -return str(source)
> +return pycompat.bytestr(source)
> source.path = posixpath.normpath(source.path)
bytes()
> subrepo.py:399
> parent.path =
pulkit added a comment.
In https://phab.mercurial-scm.org/D1795#31282, @yuja wrote:
> `bytes()` or `"%d"` is preferred. Can you send a follow up?
I am not sure which one needs to be changed.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1795
To:
yuja added a comment.
`bytes()` or `"%d"` is preferred. Can you send a follow up?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1795
To: pulkit, #hg-reviewers, durin42
Cc: yuja, mercurial-devel
___
Mercurial-devel
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG35fb3367f72d: py3: use pycompat.bytestr() instead of str()
(authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1795?vs=4672=4778
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1795
AFFECTED FILES
mercurial/debugcommands.py
mercurial/subrepo.py
mercurial/verify.py
CHANGE
