D1998: wireproto: define and use types for wire protocol commands

2018-02-07 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGef683a0fd21f: wireproto: define and use types for wire protocol commands (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1998: wireproto: define and use types for wire protocol commands

2018-02-07 Thread durin42 (Augie Fackler)
durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. I'm sold. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1998 To: indygreg, #hg-reviewers, durin42 Cc: durin42, mercurial-devel

D1998: wireproto: define and use types for wire protocol commands

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg added a comment. In https://phab.mercurial-scm.org/D1998#34740, @durin42 wrote: > I'm curious what registrations you need that don't fit in 2-tuples. Can I see a sample of where that's going? I'll be adding additional attributes to `@wireprotocommand` in future series.

D1998: wireproto: define and use types for wire protocol commands

2018-02-07 Thread durin42 (Augie Fackler)
durin42 added a comment. I'm curious what registrations you need that don't fit in 2-tuples. Can I see a sample of where that's going? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1998 To: indygreg, #hg-reviewers Cc: durin42, mercurial-devel

D1998: wireproto: define and use types for wire protocol commands

2018-02-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Wire protocol commands have historically been declared as 2-tuples in wireproto.commands. There are some additional features I'd like to implement that require