D2026: tests: add low-level SSH protocol tests

2018-02-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG83d67257ba90: tests: add low-level SSH protocol tests (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2026?vs=5227=5243

D2026: tests: add low-level SSH protocol tests

2018-02-05 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5227. indygreg marked 2 inline comments as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2026?vs=5184=5227 REVISION DETAIL https://phab.mercurial-scm.org/D2026 AFFECTED FILES tests/sshprotoext.py

D2026: tests: add low-level SSH protocol tests

2018-02-05 Thread indygreg (Gregory Szorc)
indygreg marked 2 inline comments as done. indygreg added inline comments. INLINE COMMENTS > lothiraldan wrote in test-ssh-proto.t:114 > Is the SSHSERVERMODE needed here? Yes. `dummyssh` will run `hg serve --stdio` and that process needs to inherit the environment variable so it ignores the

D2026: tests: add low-level SSH protocol tests

2018-02-05 Thread lothiraldan (Boris Feld)
lothiraldan added inline comments. INLINE COMMENTS > test-ssh-proto.t:114 > + > + $ SSHSERVERMODE=no-hello hg --debug debugpeer ssh://user@dummy/server > + running * "*/tests/dummyssh" 'user@dummy' 'hg -R server serve --stdio' > (glob) Is the SSHSERVERMODE needed here? >

D2026: tests: add low-level SSH protocol tests

2018-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We don't really have good low-level tests for the behavior of the SSH wire protocol. This commit attempts to establish some. The added tests consist of a