This revision was automatically updated to reflect the committed changes.
Closed by commit rHG80a2b8ae42a1: sshpeer: move handshake outside of sshpeer
(authored by indygreg, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D2034?vs=5235=5251#toc
REPOSITORY
rHG
indygreg updated this revision to Diff 5235.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2034?vs=5229=5235
REVISION DETAIL
https://phab.mercurial-scm.org/D2034
AFFECTED FILES
mercurial/sshpeer.py
tests/sshprotoext.py
indygreg updated this revision to Diff 5229.
indygreg marked an inline comment as done.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2034?vs=5192=5229
REVISION DETAIL
https://phab.mercurial-scm.org/D2034
AFFECTED FILES
mercurial/sshpeer.py
indygreg marked an inline comment as done.
indygreg added inline comments.
INLINE COMMENTS
> lothiraldan wrote in sshpeer.py:422
> Nit: Could the except block could be replaced by a finally block?
No, because the pipes are used for the remainder of the connection.
I would like to switch peers
lothiraldan added inline comments.
INLINE COMMENTS
> sshpeer.py:175
> +
> +requestlog = ui.configbool('devel', 'debug.peer-request')
> +
Nit that could be outside of the try: Except:
> sshpeer.py:422
> +_cleanuppipes(ui, pipei, pipeo, pipee)
> +raise
> +
Nit: Could the
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
With the handshake now performed before a peer class is instantiated,
we can now instantiate a different peer class depending on the results
of the handshake.
