D2061: sshpeer: initial definition and implementation of new SSH protocol

2018-02-07 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG48a3a9283f09: sshpeer: initial definition and implementation of new SSH protocol (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2061: sshpeer: initial definition and implementation of new SSH protocol

2018-02-07 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > joerg.sonnenberger wrote in test-ssh-proto.t:396 > I'm a bit concerned about the order here. I would prefer to stay with the > spirit of the original SSH protocol and go with the following order instead: > > - client sends hello to the server >

D2061: sshpeer: initial definition and implementation of new SSH protocol

2018-02-07 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger added inline comments. INLINE COMMENTS > test-ssh-proto.t:396 > + > upgrade 2e82ab3f-9ce3-4b4e-8f8c-6fd1c0e9e23a > proto=irrelevant1%2Cirrelevant2 > + > hello > + > between I'm a bit concerned about the order here. I would prefer to stay with the spirit of the original

D2061: sshpeer: initial definition and implementation of new SSH protocol

2018-02-06 Thread indygreg (Gregory Szorc)
indygreg added a comment. I want to emphasize that I'm not committed to any implementation detail at this point in time. I've very opened minded about alternatives and making backwards incompatible changes throughout the 4.6 release cycle. That being said, I am trying to make forward

D2061: sshpeer: initial definition and implementation of new SSH protocol

2018-02-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The existing SSH protocol has several design flaws. Future commits will elaborate on these flaws as new features are introduced to combat these flaws. For now,