quark updated this revision to Diff 6672.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2068?vs=6671&id=6672
REVISION DETAIL
https://phab.mercurial-scm.org/D2068
AFFECTED FILES
mercurial/revlog.py
tests/test-lfs-bundle.t
tests/test-revlog-raw.py
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG5c47fa90bf13: revlog: do not use delta for lfs revisions
(authored by quark, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2068?vs=6668&id=6671
quark added inline comments.
INLINE COMMENTS
> indygreg wrote in test-revlog-raw.py:156-161
> I feel like this should be checking against specific flags. But since this is
> a test, I'm fine accepting this. We can fix in a follow-up if the logic is
> wrong.
Seems I missed this line somehow. Wi
indygreg accepted this revision.
indygreg added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> test-revlog-raw.py:156-161
> +if r == 0 or rlog.flags(r):
> text = rlog.revision(r, raw=True)
> cachedelta = None
> else:
quark updated this revision to Diff 6668.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2068?vs=6470&id=6668
REVISION DETAIL
https://phab.mercurial-scm.org/D2068
AFFECTED FILES
mercurial/revlog.py
tests/test-lfs-bundle.t
tests/test-revlog-raw.py
quark added inline comments.
INLINE COMMENTS
> ryanmce wrote in revlog.py:2110
> Then why is this `REVIDX_KNOWN_FLAGS` and not `REVIDX_RAWTEXT_CHANGING_FLAGS`?
>
> Given the number of questions here from me and others, I think the comment
> could use extension at least so future readers underst
quark updated this revision to Diff 6470.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2068?vs=5651&id=6470
REVISION DETAIL
https://phab.mercurial-scm.org/D2068
AFFECTED FILES
mercurial/revlog.py
tests/test-lfs-bundle.t
tests/test-revlog-raw.py
ryanmce added inline comments.
INLINE COMMENTS
> quark wrote in revlog.py:2110
> `candelta` takes two revisions. Here there is only one revision. It's
> possible to pass a useless revision but that has unnecessary overhead.
>
> `candelta` also fetches `flags`, here we already know the values `f
quark added inline comments.
INLINE COMMENTS
> ryanmce wrote in revlog.py:2110
> Why is this not `candelta()`?
`candelta` takes two revisions. Here there is only one revision. It's possible
to pass a useless revision but that has unnecessary overhead.
`candelta` also fetches `flags`, here we a
ryanmce added inline comments.
INLINE COMMENTS
> revlog.py:2110
> +# no delta for flag processor revision (see "candelta" for why)
> +if flags & REVIDX_KNOWN_FLAGS:
> +deltainfo = None
Why is this not `candelta()`?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https:
quark updated this revision to Diff 5651.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2068?vs=5329&id=5651
REVISION DETAIL
https://phab.mercurial-scm.org/D2068
AFFECTED FILES
mercurial/revlog.py
tests/test-lfs-bundle.t
tests/test-revlog-raw.py
quark updated this revision to Diff 5329.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2068?vs=5328&id=5329
REVISION DETAIL
https://phab.mercurial-scm.org/D2068
AFFECTED FILES
mercurial/revlog.py
tests/test-lfs-bundle.t
tests/test-revlog-raw.py
quark updated this revision to Diff 5328.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2068?vs=5274&id=5328
REVISION DETAIL
https://phab.mercurial-scm.org/D2068
AFFECTED FILES
mercurial/revlog.py
tests/test-lfs-bundle.t
tests/test-revlog-raw.py
indygreg requested changes to this revision.
indygreg added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> revlog.py:408
> +# do not use flags != 0 (ex. LFS) revision as delta base
> +if revlog.flags(candidaterev) != REVIDX_DEFAUL
quark updated this revision to Diff 5274.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2068?vs=5270&id=5274
REVISION DETAIL
https://phab.mercurial-scm.org/D2068
AFFECTED FILES
mercurial/revlog.py
tests/test-lfs-bundle.t
tests/test-revlog-raw.py
quark updated this revision to Diff 5270.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2068?vs=5265&id=5270
REVISION DETAIL
https://phab.mercurial-scm.org/D2068
AFFECTED FILES
mercurial/revlog.py
tests/test-lfs-bundle.t
tests/test-revlog-raw.py
quark created this revision.
Herald added a reviewer: indygreg.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is similar to what we have done for changegroups. It is needed to make
sure the delta application code path can assume deltas
17 matches
Mail list logo