indygreg marked an inline comment as done.
indygreg added inline comments.
INLINE COMMENTS
> yuja wrote in wireprotoserver.py:424
> `rsp.res` here looks like an integer.
This was fixed by
https://phab.mercurial-scm.org/rHGb67d4b7e8235a1c5d16a2885801d21bf670d3b03.
REPOSITORY
rHG Mercurial
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG5767664d39a5: wireprotoserver: extract SSH response
handling functions (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
indygreg updated this revision to Diff 5342.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2091?vs=5331=5342
REVISION DETAIL
https://phab.mercurial-scm.org/D2091
AFFECTED FILES
mercurial/wireprotoserver.py
tests/sshprotoext.py
CHANGE DETAILS
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The lookup/dispatch table was cute. But it isn't needed. Future
refactors will benefit from the handlers for individual response
types living outside the
