D219: morestatus: move fb extension to core by plugging to `hg status --verbose`

2017-08-19 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in test-bisect.t:190 > What does None mean here? Oh, _conflictsmsg() is returning None which is getting printed. I will send a follow-up for this. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D219

D219: morestatus: move fb extension to core by plugging to `hg status --verbose`

2017-08-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > test-bisect.t:190 > + > + None > + # To mark the changeset good:hg bisect --good What does None mean here? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D219 To: pulkit, #hg-reviewers, durin42 Cc:

Re: D219: morestatus: move fb extension to core by plugging to `hg status --verbose`

2017-08-11 Thread Danek Duvall
durin42 (Augie Fackler) wrote: > I've heard no objections, but also the suggestion that --terse be > something like --terse-dirs or similar so it's obviously not the antonym > of --verbose. Maybe --collapse? I think that's what you do when you've got a directory tree in a GUI and you rotate

D219: morestatus: move fb extension to core by plugging to `hg status --verbose`

2017-08-11 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG96f43981c1c4: morestatus: move fb extension to core by plugging to `hg status --verbose` (authored by pulkit). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D219?vs=577=798#toc REPOSITORY

D219: morestatus: move fb extension to core by plugging to `hg status --verbose`

2017-08-11 Thread durin42 (Augie Fackler)
durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. I've heard no objections, but also the suggestion that --terse be something like --terse-dirs or similar so it's obviously not the antonym of --verbose. REPOSITORY rHG Mercurial

D219: morestatus: move fb extension to core by plugging to `hg status --verbose`

2017-08-09 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D219#4343, @durin42 wrote: > I'm still a tiny bit worried about potential confusion between --terse and --verbose (in that they're not opposites), but I'm also fine with this. I'll take it in a couple of days if I don't hear any

D219: morestatus: move fb extension to core by plugging to `hg status --verbose`

2017-08-08 Thread durin42 (Augie Fackler)
durin42 accepted this revision as: durin42. durin42 added a comment. I'm still a tiny bit worried about potential confusion between --terse and --verbose (in that they're not opposites), but I'm also fine with this. I'll take it in a couple of days if I don't hear any objections. REPOSITORY

D219: morestatus: move fb extension to core by plugging to `hg status --verbose`

2017-08-05 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 577. pulkit edited the summary of this revision. pulkit retitled this revision from "morestatus: move fb extension to core as '--repo-state' option to status" to "morestatus: move fb extension to core by plugging to `hg status --verbose`". REPOSITORY rHG