pulkit abandoned this revision.
pulkit added a comment.
In https://phab.mercurial-scm.org/D2297#39249, @yuja wrote:
> "There are around 100 occurences of open() call, it's better if we can
> prevent replacing all these calls
> "In future, when we will dropping all the compatibility
yuja added a comment.
"There are around 100 occurences of open() call, it's better if we can
prevent replacing all these calls
"In future, when we will dropping all the compatibility code, we don't have
to take care of changing pycompat.open back to open
Yeah, that's the point why
"There are around 100 occurences of open() call, it's better if we can
prevent replacing all these calls
"In future, when we will dropping all the compatibility code, we don't have
to take care of changing pycompat.open back to open
Yeah, that's the point why we have `from pycompat import open`
pulkit added a comment.
In https://phab.mercurial-scm.org/D2297#37960, @yuja wrote:
> Can you elaborate why you think it wasn't a good idea to replace open()?
>
> IMHO, it's as hackish as replacing '' with b''.
Added couple of points.
REPOSITORY
rHG Mercurial
REVISION
yuja added a comment.
Can you elaborate why you think it wasn't a good idea to replace open()?
IMHO, it's as hackish as replacing '' with b''.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2297
To: pulkit, #hg-reviewers
Cc: yuja, mercurial-devel
Can you elaborate why you think it wasn't a good idea to replace open()?
IMHO, it's as hackish as replacing '' with b''.
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This backouts changeset
https://phab.mercurial-scm.org/rHG7c54917b31f6200449bb7afd253ca0561288456a in
which code to prevent adding b'' in
front of second
