pulkit added a comment.
This one got pushed with a wrong commit message.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2367
To: durin42, #hg-reviewers, indygreg
Cc: indygreg, pulkit, mercurial-devel
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG5dbeddbf164a: narrowcommands: add some missing strkwargs
calls for py3 (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 updated this revision to Diff 5980.
durin42 edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2367?vs=5947=5980
REVISION DETAIL
https://phab.mercurial-scm.org/D2367
AFFECTED FILES
indygreg requested changes to this revision.
indygreg added a comment.
This revision now requires changes to proceed.
Let's do what @pulkit said.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2367
To: durin42, #hg-reviewers, indygreg
Cc: indygreg, pulkit,
pulkit added inline comments.
INLINE COMMENTS
> narrowcommands.py:146
> opts['exclude'] = excludes
> +opts = pycompat.strkwargs(opts)
> return orig(ui, repo, *args, **opts)
What about adding r'' prefixes to prevent the the function calls which iterate
over all the
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2367
AFFECTED FILES
hgext/narrow/narrowcommands.py
CHANGE DETAILS
diff --git