This revision was automatically updated to reflect the committed changes.
Closed by commit rHG36f21b975efb: debugcommands: add debugwireproto command
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2392?vs=6250=6283
indygreg updated this revision to Diff 6250.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2392?vs=6139=6250
REVISION DETAIL
https://phab.mercurial-scm.org/D2392
AFFECTED FILES
mercurial/debugcommands.py
tests/test-completion.t
tests/test-help.t
indygreg added a comment.
In https://phab.mercurial-scm.org/D2392#40790, @yuja wrote:
> This is OT, but I couldn't find a way to phabread this long series.
`:D2462` (the topmost patch
> in yadda) appeared to lack many changes, and `:D2392` missed some
dependency patches.
> And I
yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.
This is OT, but I couldn't find a way to phabread this long series. `:D2462`
(the topmost patch
in yadda) appeared to lack many changes, and `:D2392` missed some dependency
indygreg updated this revision to Diff 6139.
indygreg edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2392?vs=6005=6139
REVISION DETAIL
https://phab.mercurial-scm.org/D2392
AFFECTED FILES
mercurial/debugcommands.py
indygreg planned changes to this revision.
indygreg added inline comments.
INLINE COMMENTS
> debugcommands.py:2630
> +# separation. This prevents a whole class of potential bugs around
> +# shared state from interfering with server operation.
> +
I'm having second thoughts about
indygreg added a subscriber: sid0.
indygreg added a comment.
@sid0: I reckon we could find a way to take what I did in this commit and
turn it into a wire protocol conformance tester. i.e. if we could refactor the
test so it instantiates the server via alternate mechanisms, we could point
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We currently don't have a low-level mechanism for sending
arbitrary wire protocol commands. Having a generic and robust
mechanism for sending wire protocol
