D2866: contrib: fix a subtle bug in check-code's regex rewriting

2018-03-15 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGac635637ed2f: contrib: fix a subtle bug in check-codes regex rewriting (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2866: contrib: fix a subtle bug in check-code's regex rewriting

2018-03-15 Thread pulkit (Pulkit Goyal)
pulkit accepted this revision. pulkit added a comment. Looks good to me but I am not feeling confident enough to push this. Queued the first three. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2866 To: durin42, #hg-reviewers, pulkit Cc: pulkit,

D2866: contrib: fix a subtle bug in check-code's regex rewriting

2018-03-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We rewrite `\s` to `[ \t]` when preparing our regular expressions, but we previously weren't working to avoid having nested sets. Previously, Python let this