This revision was automatically updated to reflect the committed changes.
Closed by commit rHG702a26fec3e2: bundlerepo: move temp bundle creation to a
separate function (authored by durham).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D288?vs=1215&id=122
durham added a comment.
I fixed the comment and renamed read to readfn. I know we usually do renames
as separate from code moves, but this was a tiny rename (only one use).
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D288
To: durham, #hg-reviewers, indygreg
C
durham updated this revision to Diff 1215.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D288?vs=658&id=1215
REVISION DETAIL
https://phab.mercurial-scm.org/D288
AFFECTED FILES
mercurial/bundlerepo.py
CHANGE DETAILS
diff --git a/mercurial/bundlerepo.
krbullock added inline comments.
INLINE COMMENTS
> martinvonz wrote in bundlerepo.py:322
> I think we usually use a "fn" prefix for function arguments. I think "readfn"
> would be clearer.
I agree, but as it is, this is simple code movement. Usually we like renames to
be done in separate chang
martinvonz added inline comments.
INLINE COMMENTS
> bundlerepo.py:322
>
> +def _writetempbundle(self, read, suffix, header=''):
> +"""Write a temporary file to disk
I think we usually use a "fn" prefix for function arguments. I think "readfn"
would be clearer.
REPOSITORY
rHG Me
indygreg requested changes to this revision.
indygreg added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> bundlerepo.py:325-326
> +
> +This is closure because we need to make sure this tracked by
> +self.tempfile for cleanup purposes."""
> +
lothiraldan added a comment.
LGTM
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D288
To: durham, #hg-reviewers
Cc: lothiraldan, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https:/
durham created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
A future patch will refactor certain parts of bundlerepo initiatlization such
that we need to create temp bundles from another function. Let's move this to
anothe
