yuja added inline comments.
INLINE COMMENTS
> stringutil.py:526
> + __future__.unicode_literals.compiler_flag, True)
> +return eval(code, globs, {})
Can't we use `ast.literal_eval()` instead of unsafe `eval()` ?
https://docs.python.org/2.7/library/ast.html#ast.literal_eval
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGcc5a040fe150: wireproto: syntax for encoding CBOR into
frames (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2948?vs=7437&i
durin42 added a comment.
I have misgivings about this code that serves testing living in core, but I
don't see a better solution offhand.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2948
To: indygreg, #hg-reviewers
Cc: durin42, mercurial-devel
__
indygreg updated this revision to Diff 7437.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2948?vs=7352&id=7437
REVISION DETAIL
https://phab.mercurial-scm.org/D2948
AFFECTED FILES
mercurial/debugcommands.py
mercurial/utils/stringutil.py
mercurial
On Thu, Mar 29, 2018 at 9:36 AM, Josef 'Jeff' Sipek
wrote:
> On Wed, Mar 28, 2018 at 22:06:17 +, indygreg (Gregory Szorc) wrote:
> > indygreg updated this revision to Diff 7352.
> >
> > REPOSITORY
> > rHG Mercurial
> >
> > CHANGES SINCE LAST UPDATE
> > https://phab.mercurial-scm.org/D2948
On Wed, Mar 28, 2018 at 22:06:17 +, indygreg (Gregory Szorc) wrote:
> indygreg updated this revision to Diff 7352.
>
> REPOSITORY
> rHG Mercurial
>
> CHANGES SINCE LAST UPDATE
> https://phab.mercurial-scm.org/D2948?vs=7327&id=7352
>
> REVISION DETAIL
> https://phab.mercurial-scm.org/D2
indygreg updated this revision to Diff 7352.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2948?vs=7327&id=7352
REVISION DETAIL
https://phab.mercurial-scm.org/D2948
AFFECTED FILES
mercurial/debugcommands.py
mercurial/utils/stringutil.py
mercurial
indygreg updated this revision to Diff 7327.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2948?vs=7310&id=7327
REVISION DETAIL
https://phab.mercurial-scm.org/D2948
AFFECTED FILES
mercurial/debugcommands.py
mercurial/wireprotoframing.py
tests/tes
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We just vendored a library for encoding and decoding the CBOR
data format. While the intent of that vendor was to support state
files, CBOR is really a nice dat