D3092: simplestore: shore up lookup errors

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGdd2753729853: simplestore: shore up lookup errors (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3092?vs=7674=7802

D3092: simplestore: shore up lookup errors

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. > When revisions or nodes can't be resolved, we're expected to raise > an error.LookupError. When I ported code from revlog.py, I failed > to realize that "LookupError" in that module is aliased to > error.LookupError. I thought we were using the builtin

D3092: simplestore: shore up lookup errors

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When revisions or nodes can't be resolved, we're expected to raise an error.LookupError. When I ported code from revlog.py, I failed to realize that