This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8919cc4f63b4: patchbomb: python 3 really wants those email
addresses in unicode (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 updated this revision to Diff 10193.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3957?vs=9613=10193
REVISION DETAIL
https://phab.mercurial-scm.org/D3957
AFFECTED FILES
hgext/patchbomb.py
CHANGE DETAILS
diff --git a/hgext/patchbomb.py
yuja added a comment.
> - sendmail(sender_addr, to + bcc + cc, fp.getvalue()) +alldests
= to + bcc + cc +alldests = [pycompat.strurl(d) for d in alldests]
+sendmail(sender_addr, alldests, fp.getvalue())
`encoding.strfromlocal()` to avoid unicode
> -sendmail(sender_addr, to + bcc + cc, fp.getvalue())
> +alldests = to + bcc + cc
> +alldests = [pycompat.strurl(d) for d in alldests]
> +sendmail(sender_addr, alldests, fp.getvalue())
`encoding.strfromlocal()` to avoid unicode exception.
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
At this point, test-patchbomb-tls.t almost passes on Python 3, but I'm
not really sure what the issue is: we just get a `abort: Connection
unexpectedly closed`
