D3976: grep: add MULTIREV support to --allfiles flag

2018-08-07 Thread sangeet259 (Sangeet Kumar Mishra)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf3f109971359: grep: add MULTIREV support to --allfiles flag (authored by sangeet259, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3976: grep: add MULTIREV support to --allfiles flag

2018-08-07 Thread sangeet259 (Sangeet Kumar Mishra)
sangeet259 added a comment. In https://phab.mercurial-scm.org/D3976#64274, @yuja wrote: > Queued with minor cleanup, thanks. > > As a follow up, can you fix `hg grep --all-files -rREVS FILE` to scan > unchanged revisions? Sure REPOSITORY rHG Mercurial REVISION DETAIL

D3976: grep: add MULTIREV support to --allfiles flag

2018-08-07 Thread yuja (Yuya Nishihara)
yuja added a comment. Queued with minor cleanup, thanks. As a follow up, can you fix `hg grep --all-files -rREVS FILE` to scan unchanged revisions? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3976 To: sangeet259, #hg-reviewers Cc: yuja,

Re: D3976: grep: add MULTIREV support to --allfiles flag

2018-08-07 Thread Yuya Nishihara
Queued with minor cleanup, thanks. As a follow up, can you fix `hg grep --all-files -rREVS FILE` to scan unchanged revisions? ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

D3976: grep: add MULTIREV support to --allfiles flag

2018-08-07 Thread sangeet259 (Sangeet Kumar Mishra)
sangeet259 updated this revision to Diff 10059. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3976?vs=10058=10059 REVISION DETAIL https://phab.mercurial-scm.org/D3976 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py tests/test-grep.t

D3976: grep: add MULTIREV support to --allfiles flag

2018-08-07 Thread sangeet259 (Sangeet Kumar Mishra)
sangeet259 updated this revision to Diff 10058. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3976?vs=10057=10058 REVISION DETAIL https://phab.mercurial-scm.org/D3976 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py tests/test-grep.t

D3976: grep: add MULTIREV support to --allfiles flag

2018-08-07 Thread sangeet259 (Sangeet Kumar Mishra)
sangeet259 updated this revision to Diff 10057. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3976?vs=9937=10057 REVISION DETAIL https://phab.mercurial-scm.org/D3976 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py tests/test-grep.t

Re: D3976: grep: add MULTIREV support to --allfiles flag

2018-08-06 Thread Yuya Nishihara
Looks mostly good. One nit. > @@ -2748,7 +2749,7 @@ > for fn in sorted(revfiles.get(rev, [])): > states = matches[rev][fn] > copy = copies.get(rev, {}).get(fn) > -if fn in skip: > +if fn in skip and not all_files: > if

D3976: grep: add MULTIREV support to --allfiles flag

2018-08-06 Thread yuja (Yuya Nishihara)
yuja added a comment. Looks mostly good. One nit. > @@ -2748,7 +2749,7 @@ > > for fn in sorted(revfiles.get(rev, [])): > states = matches[rev][fn] > copy = copies.get(rev, {}).get(fn) > > - if fn in skip: +if fn in skip and not all_files: if copy:

D3976: grep: add MULTIREV support to --allfiles flag

2018-08-05 Thread sangeet259 (Sangeet Kumar Mishra)
sangeet259 updated this revision to Diff 9937. sangeet259 edited the summary of this revision. sangeet259 retitled this revision from "grep: add MULTIREV support to --all-files flag" to "grep: add MULTIREV support to --allfiles flag". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE