yuja added a comment.
> For the record, I'm not thrilled about queuing C code with known bugs.
Me neither. If there weren't unmanageable number of patches, I wouldn't
queue.
The fixes are pushed as
https://phab.mercurial-scm.org/rHG05c1f5f49ebbd53b6a520991c86e6311617d8d6e,
> For the record, I'm not thrilled about queuing C code with known bugs.
Me neither. If there weren't unmanageable number of patches, I wouldn't
queue.
The fixes are pushed as 05c1f5f49ebb, f7d8fb2ed8a8, and dcd395dc98d8. Thanks.
___
Mercurial-devel
indygreg added a comment.
For the record, I'm not thrilled about queuing C code with known bugs.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4108
To: martinvonz, #hg-reviewers
Cc: indygreg, yuja, mercurial-devel
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGd1bc0e7c862b: index: extract a type for the nodetree
(authored by martinvonz, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D4108?vs=9911=9972#toc
REPOSITORY
rHG Mercurial
Queued, but there seem to be a couple of minor errors. Can you fix them
if they remain in the code after the refactor?
> static int nt_new(indexObject *self)
> {
> if (self->ntlength == self->ntcapacity) {
> - if (self->ntcapacity >= INT_MAX / (sizeof(nodetree) * 2)) {
> +
yuja added a comment.
Queued, but there seem to be a couple of minor errors. Can you fix them
if they remain in the code after the refactor?
> static int nt_new(indexObject *self)
> {
> if (self->ntlength == self->ntcapacity) {
>
> - if (self->ntcapacity >= INT_MAX /
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is a first step towards exposing the nodetree as a Python type.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4108
