This revision was automatically updated to reflect the committed changes.
Closed by commit rHG7a759ad2d06d: shortest: use nodetree for finding shortest
node within revset (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
martinvonz added a comment.
In https://phab.mercurial-scm.org/D4120#66682, @yuja wrote:
> > Hmm, it passes for me. How does it fail for you?
>
> Okay, it's a real bug. Filling Py_ssize_t as int.
Fixed that and bumped the version. Thanks for helping me find that.
REPOSITORY
martinvonz updated this revision to Diff 10491.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4120?vs=10485=10491
REVISION DETAIL
https://phab.mercurial-scm.org/D4120
AFFECTED FILES
mercurial/cext/parsers.c
mercurial/cext/revlog.c
yuja added a comment.
And can you bump cext version again as new code depends on nodetree.insert()?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4120
To: martinvonz, #hg-reviewers
Cc: yuja, mercurial-devel
___
And can you bump cext version again as new code depends on nodetree.insert()?
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
> Hmm, it passes for me. How does it fail for you?
Okay, it's a real bug. Filling Py_ssize_t as int.
```
static PyObject *nt_insert_py(nodetree *self, PyObject *args)
{
Py_ssize_t rev;
const char *node;
if (!PyArg_ParseTuple(args, "i", ))
```
```
Traceback (most
yuja added a comment.
> Hmm, it passes for me. How does it fail for you?
Okay, it's a real bug. Filling Py_ssize_t as int.
static PyObject *nt_insert_py(nodetree *self, PyObject *args)
{
Py_ssize_t rev;
const char *node;
if (!PyArg_ParseTuple(args,
martinvonz added a comment.
In https://phab.mercurial-scm.org/D4120#2, @yuja wrote:
> test-revisions.t fails probably because null.
Hmm, it passes for me. How does it fail for you?
> I've queued up to the previous
> patch.
>
>> static int nt_init_py(nodetree
martinvonz updated this revision to Diff 10485.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4120?vs=10458=10485
REVISION DETAIL
https://phab.mercurial-scm.org/D4120
AFFECTED FILES
mercurial/cext/revlog.c
mercurial/scmutil.py
CHANGE DETAILS
test-revisions.t fails probably because null. I've queued up to the previous
patch.
> static int nt_init_py(nodetree *self, PyObject *args)
> {
> - PyObject *index;
> + indexObject *index;
Dropped this change as it's unrelated to this patch, and the index variable
is casted to
yuja added a comment.
test-revisions.t fails probably because null. I've queued up to the previous
patch.
> static int nt_init_py(nodetree *self, PyObject *args)
> {
>
> - PyObject *index; + indexObject *index;
Dropped this change as it's unrelated to this patch, and
martinvonz added a comment.
I have rebased this series and run all tests in pure and native mode, so this
should be ready to queue as far as I can tell.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4120
To: martinvonz, #hg-reviewers
Cc: mercurial-devel
martinvonz updated this revision to Diff 10458.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4120?vs=10275=10458
REVISION DETAIL
https://phab.mercurial-scm.org/D4120
AFFECTED FILES
mercurial/cext/revlog.c
mercurial/scmutil.py
CHANGE DETAILS
martinvonz updated this revision to Diff 10275.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4120?vs=10274=10275
REVISION DETAIL
https://phab.mercurial-scm.org/D4120
AFFECTED FILES
mercurial/cext/revlog.c
mercurial/scmutil.py
CHANGE DETAILS
martinvonz updated this revision to Diff 10274.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4120?vs=10095=10274
REVISION DETAIL
https://phab.mercurial-scm.org/D4120
AFFECTED FILES
mercurial/cext/revlog.c
mercurial/scmutil.py
CHANGE DETAILS
martinvonz updated this revision to Diff 10095.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4120?vs=10084=10095
REVISION DETAIL
https://phab.mercurial-scm.org/D4120
AFFECTED FILES
mercurial/cext/revlog.c
mercurial/scmutil.py
CHANGE DETAILS
martinvonz updated this revision to Diff 10084.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4120?vs=10044=10084
REVISION DETAIL
https://phab.mercurial-scm.org/D4120
AFFECTED FILES
mercurial/cext/revlog.c
mercurial/scmutil.py
CHANGE DETAILS
martinvonz updated this revision to Diff 10044.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4120?vs=9985=10044
REVISION DETAIL
https://phab.mercurial-scm.org/D4120
AFFECTED FILES
mercurial/cext/revlog.c
mercurial/scmutil.py
CHANGE DETAILS
diff
martinvonz updated this revision to Diff 9985.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4120?vs=9926=9985
REVISION DETAIL
https://phab.mercurial-scm.org/D4120
AFFECTED FILES
mercurial/cext/revlog.c
mercurial/scmutil.py
CHANGE DETAILS
diff
martinvonz updated this revision to Diff 9926.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4120?vs=9923=9926
REVISION DETAIL
https://phab.mercurial-scm.org/D4120
AFFECTED FILES
mercurial/cext/revlog.c
mercurial/scmutil.py
CHANGE DETAILS
diff
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This speeds up `hg log -T '{shortest(node,1)}\n'` in my repo from 12s
to 4.5s. That's very close to the 4.1s it takes without the
disambiguation revset
21 matches
Mail list logo
