foozy added a comment.
Sorry, I overlooked delivery error of reply to phabricator.
This is re-sending of the reply at Sat, 18 Aug 2018 15:18:10 +0900,
which was cc-ed to mercurial-devel@mercurial-scm.org.
At Wed, 15 Aug 2018 19:00:51 +,
sheehan (Connor Sheehan) wrote:
sheehan planned changes to this revision.
sheehan added a comment.
In https://phab.mercurial-scm.org/D4283#65988, @indygreg wrote:
> This seems like a strict improvement.
>
> But the proper way to register web commands from extensions would be to go
through the `registrar` API and
At Wed, 15 Aug 2018 19:00:51 +,
sheehan (Connor Sheehan) wrote:
[snip]
> diff --git a/mercurial/hgweb/hgweb_mod.py b/mercurial/hgweb/hgweb_mod.py
> --- a/mercurial/hgweb/hgweb_mod.py
> +++ b/mercurial/hgweb/hgweb_mod.py
> @@ -354,7 +354,7 @@
> cmd = cmd[style + 1:]
>
>
indygreg added a comment.
This seems like a strict improvement.
But the proper way to register web commands from extensions would be to go
through the `registrar` API and have the extension loader look for a well-named
symbol in each extension module that is loaded and hgweb would
sheehan created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This commit fixes the `@webcommand` decorator used to define
webcommands. Although webcommands are currently using this
decorator, it does not behave as
