D451: [RFC] revset: remove order information from tree

quark updated this revision to Diff 1097. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D451?vs=1096=1097 REVISION DETAIL https://phab.mercurial-scm.org/D451 AFFECTED FILES mercurial/revset.py mercurial/revsetlang.py tests/test-revset.t CHANGE

D451: [RFC] revset: remove order information from tree

quark updated this revision to Diff 1096. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D451?vs=1095=1096 REVISION DETAIL https://phab.mercurial-scm.org/D451 AFFECTED FILES mercurial/revset.py mercurial/revsetlang.py tests/test-revset.t CHANGE

D451: [RFC] revset: remove order information from tree

quark added inline comments. INLINE COMMENTS > test-revset.t:2893 > , > -> > +> >0 This is caused by `fullreposet` having a default order. If we remove that, it would be optimized to `` here. REPOSITORY rHG Mercurial REVISION DETAIL

D451: [RFC] revset: remove order information from tree

quark updated this revision to Diff 1095. quark edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D451?vs=1094=1095 REVISION DETAIL https://phab.mercurial-scm.org/D451 AFFECTED FILES mercurial/revset.py

D451: [RFC] revset: remove order information from tree

quark updated this revision to Diff 1094. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D451?vs=1093=1094 REVISION DETAIL https://phab.mercurial-scm.org/D451 AFFECTED FILES mercurial/revset.py mercurial/revsetlang.py tests/test-revset.t CHANGE

D451: [RFC] revset: remove order information from tree

quark updated this revision to Diff 1093. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D451?vs=1092=1093 REVISION DETAIL https://phab.mercurial-scm.org/D451 AFFECTED FILES mercurial/revset.py mercurial/revsetlang.py tests/test-revset.t CHANGE

D451: [RFC] revset: remove order information from tree

quark updated this revision to Diff 1092. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D451?vs=1091=1092 REVISION DETAIL https://phab.mercurial-scm.org/D451 AFFECTED FILES mercurial/revset.py mercurial/revsetlang.py tests/test-revset.t CHANGE

D451: [RFC] revset: remove order information from tree

quark added a subscriber: yuja. quark added a comment. @yuja Let me know if this can simplify `matchtree`, `buildtree` implementation. INLINE COMMENTS > test-revset.t:2502 > >$ try -p optimized '(reverse(contains("a")) + 2) & 0:2' >* optimized: The new code is less efficient

D451: [RFC] revset: remove order information from tree

quark updated this revision to Diff 1091. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D451?vs=1090=1091 REVISION DETAIL https://phab.mercurial-scm.org/D451 AFFECTED FILES mercurial/revset.py mercurial/revsetlang.py tests/test-revset.t CHANGE

D451: [RFC] revset: remove order information from tree

quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Keeping `order` in tree makes AST operation harder. And there could be certain invalid cases, like: A(order=define) | B(order=define)