This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb77f2ea51da5: py3: fix kwargs handling in
hgext/fastannotate.py (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
pulkit updated this revision to Diff 11101.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4588?vs=11042=11101
REVISION DETAIL
https://phab.mercurial-scm.org/D4588
AFFECTED FILES
hgext/fastannotate/commands.py
CHANGE DETAILS
diff --git
pulkit added inline comments.
INLINE COMMENTS
> indygreg wrote in commands.py:212-217
> Shouldn't we be doing the ``pycompat.byteskwargs()` at the beginning of the
> function and using regular string literals on the keys we set?
We can do that, but then in the end we have to do
indygreg requested changes to this revision.
indygreg added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> commands.py:212-217
> +opts[r'text'] = True
>
> # check if we need to do prefetch (client-side)
> -rev = opts.get('rev')
> +rev =
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4588
AFFECTED FILES
hgext/fastannotate/commands.py
CHANGE DETAILS
diff --git
