indygreg added a comment.
FWIW I would like to rewrite all of filelog (and this API) to be in terms of
nodes. My hands are somewhat tied with this function due to how all the
functions are implemented in terms of revs today. We'll get there eventually...
REPOSITORY
rHG Mercurial
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG842ffcf1d42f: storageutil: extract most of emitrevisions()
to standalone function (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 added a comment.
Oh, I just got to https://phab.mercurial-scm.org/D4805. I think the helper is
still of somewhat limited utility and truly novel storage engines will end up
totally reimplementing emitrevisions, but that's fine.
REPOSITORY
rHG Mercurial
REVISION DETAIL
durin42 requested changes to this revision.
durin42 added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> storageutil.py:266
> +
> +def emitrevisions(store, revs, resultcls, deltaparentfn, candeltafn,
> + rawsizefn, revdifffn, flagsfn,
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
As part of implementing a storage backend, I found myself copying
most of revlog.emitrevisions(). This code is highly nuanced and it
bothered me greatly to be
