This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8d75b9effa07: bundle2: fixed usage of an attribute that was
removed in py3k (authored by alex.gaynor).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D482?vs=1164&
lothiraldan added a comment.
Good for me.
I have the impression that we tend to defined static data (like
`pycompat.bytestr(string.ascii_letters)` or some translations) inside functions
while they could be defined once at module level. Is it intentional, is it for
reducing startup time?
durin42 added a comment.
In https://phab.mercurial-scm.org/D482#7640, @lothiraldan wrote:
> Would it be possible to define `pycompat.bytestr(string.ascii_letters)` at
the module level once and for all?
I think I'd bias against this, just because it's only used in six or so
places
lothiraldan added a comment.
Would it be possible to define `pycompat.bytestr(string.ascii_letters)` at
the module level once and for all?
REPOSITORY
rHG Mercurial
BRANCH
py3k-stuff (bookmark) on default (branch)
REVISION DETAIL
https://phab.mercurial-scm.org/D482
To: alex.gaynor, du
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
The commit message should likely say something about how the existing use of
`string.letters` was logically wrong, since it is locale dependent.
`string.ascii_letters` is definitely the
alex.gaynor created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
BRANCH
py3k-stuff (bookmark) on default (branch)
REVISION DETAIL
https://phab.mercurial-scm.org/D482
AFFECTED FILES
mercurial/bundle2.py
CHANGE
