This revision was automatically updated to reflect the committed changes.
Closed by commit rHG191fac9ff9d3: obsutil: fix the issue5686 (authored by
khanchi97, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5474?vs=12962=13105
REVISION
Ready for review.
On Sun 23 Dec, 2018, 6:19 PM khanchi97 (Sushil khanchi) <
phabrica...@mercurial-scm.org wrote:
> khanchi97 updated this revision to Diff 12962.
>
> REPOSITORY
> rHG Mercurial
>
> CHANGES SINCE LAST UPDATE
> https://phab.mercurial-scm.org/D5474?vs=12956=12962
>
> REVISION
khanchi97 updated this revision to Diff 12962.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5474?vs=12956=12962
REVISION DETAIL
https://phab.mercurial-scm.org/D5474
AFFECTED FILES
mercurial/obsutil.py
tests/test-obsmarker-template.t
khanchi97 added a comment.
@av6 Thanks for the review. I will update it.
INLINE COMMENTS
> av6 wrote in test-obsmarker-template.t:2511
> The new output looks somewhat more correct, but not quite. This changeset
> definitely wasn't just pruned, but it also wasn't rewritten either: it was
>
av6 added inline comments.
INLINE COMMENTS
> test-obsmarker-template.t:2511
>| @ 471597cad322
> - |/ Obsfate: pruned;
> + |/ Obsfate: rewritten as 2:617adc3a144c by test (at 1970-01-01 00:00
> +);
>o ea207398892e
The new output looks somewhat more correct, but not
khanchi97 added a comment.
Please take a look at tests changes, as I accepted these changes using
--interactive flag thinking it as a expected change.
I think I can't add tests which will reflect the expected bahivour for this
issue here in mercurial, so I will send a test patch in evolve.
khanchi97 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
While traversing the obsolescence graph to find the successors sets
of csets:
In its 4th case (read comments of obsutil.successorssets to see
all 4
