yuja added a comment.
Looks mostly good.
Can you update the commit message to conform to our style?
https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist
You'll see some lint errors if you run `test-check-*`. And you'll probably
need to update
Looks mostly good.
Can you update the commit message to conform to our style?
https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist
You'll see some lint errors if you run `test-check-*`. And you'll probably
need to update `test-completion.t`.
> opts =
navaneeth.suresh added a comment.
@yuja Thank you so much for the information. I've updated the revision.
Please review when you're free.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5477
To: navaneeth.suresh, #hg-reviewers
Cc: pulkit, yuja, mercurial-devel
navaneeth.suresh updated this revision to Diff 12978.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5477?vs=12969=12978
REVISION DETAIL
https://phab.mercurial-scm.org/D5477
AFFECTED FILES
mercurial/commands.py
tests/test-branches.t
CHANGE DETAILS
yuja added a comment.
> > ctx points to the tipmost branch head. so `rev not in revs` doesn't
mean any
> > of the `revs` do not belong to the branch.
>
> Is there any possibility of workaround within this iteration itself
@yuja? I can do outside the current loop by creating a
> > ctx points to the tipmost branch head. so `rev not in revs` doesn't mean
> any
> > of the `revs` do not belong to the branch.
>
> Is there any possibility of workaround within this iteration itself @yuja?
> I can do outside the current loop by creating a branches list and map it by
navaneeth.suresh added a comment.
In https://phab.mercurial-scm.org/D5477#81095, @yuja wrote:
> > fm.startitem()
> >
> > +rev = ctx.rev()
> > +if opts.get('rev') and rev not in revs:
> > +continue
>
> ctx points to the tipmost branch head. so
yuja added a comment.
> 0. I move metaedit command to core
> 1. I move branch changing functionality to metaedit
No opinion about 0 and 1. I've never used the metaedit.
> 2. and then we implement `hg branch -r ` to show a branch name?
I want to avoid it because no other
> 0. I move metaedit command to core
> 1. I move branch changing functionality to metaedit
No opinion about 0 and 1. I've never used the metaedit.
> 2. and then we implement `hg branch -r ` to show a branch name?
I want to avoid it because no other namespace commands (i.e. bookmark and
yuja added a comment.
> fm.startitem()
>
> +rev = ctx.rev()
> +if opts.get('rev') and rev not in revs:
> +continue
ctx points to the tipmost branch head. so `rev not in revs` doesn't mean any
of the `revs` do not belong to the branch.
REPOSITORY
> fm.startitem()
> +rev = ctx.rev()
> +if opts.get('rev') and rev not in revs:
> +continue
ctx points to the tipmost branch head. so `rev not in revs` doesn't mean any
of the `revs` do not belong to the branch.
___
pulkit added subscribers: yuja, pulkit.
pulkit added a comment.
Didn't looked at the code in detail yet, but this patch needs tests.
Also, @yuja how do you think of the following:
0. I move metaedit command to core
1. I move branch changing functionality to metaedit
2. and
navaneeth.suresh created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5477
AFFECTED FILES
mercurial/commands.py
CHANGE DETAILS
diff --git a/mercurial/commands.py
13 matches
Mail list logo
