This revision was automatically updated to reflect the committed changes.
Closed by commit rHG92b3811fd15f: hg-docker: fix Python 3.4 compatibility (for
CentOS 7) (authored by Mathias De Mare mathias.de_m...@nokia.com,
committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
Mathiasdm updated this revision to Diff 13208.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5570?vs=13175=13208
REVISION DETAIL
https://phab.mercurial-scm.org/D5570
AFFECTED FILES
contrib/packaging/hg-docker
CHANGE DETAILS
diff --git
Mathiasdm added a comment.
In https://phab.mercurial-scm.org/D5570#82332, @yuja wrote:
> > +if p.returncode:
> > +raise Exception('failed to build docker image: %s %s' %
(p.stdout, p.stderr))
>
> Can you change the exception type? test-check-code.t complains about it.
yuja added a comment.
> +if p.returncode:
> +raise Exception('failed to build docker image: %s %s' %
(p.stdout, p.stderr))
Can you change the exception type? test-check-code.t complains about it.
REPOSITORY
rHG Mercurial
REVISION DETAIL
> +if p.returncode:
> +raise Exception('failed to build docker image: %s %s' % (p.stdout,
> p.stderr))
Can you change the exception type? test-check-code.t complains about it.
___
Mercurial-devel mailing list
Mathiasdm created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I realize Mercurial is not targetting Python 3.4 compatibility,
but without this change, it's not even possible to build it on
CentOS 7 (and I assume the same