pulkit updated this revision to Diff 1731.
pulkit edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D614?vs=1581=1731
REVISION DETAIL
https://phab.mercurial-scm.org/D614
AFFECTED FILES
mercurial/dispatch.py
pulkit planned changes to this revision.
pulkit added inline comments.
INLINE COMMENTS
> durham wrote in registrar.py:152
> Should we throw an exception instead? Seems like a programmer error
Yes, thanks!
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D614
To:
durham added inline comments.
INLINE COMMENTS
> registrar.py:152
> +if hiddenlevel not in set([0, 1, 2]):
> +hiddenlevel = 0
> +func.hiddenlevel = hiddenlevel
Should we throw an exception instead? Seems like a programmer error
REPOSITORY
rHG Mercurial
REVISION
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Making the hiddenlevel a attribute of function will help us in deciding the
access level in the dispatch and then we will a internal config about the
