This revision now requires changes to proceed.
baymax added a comment.
baymax requested changes to this revision.
There seems to have been no activities on this Diff for the past 3 Months.
By policy, we are automatically moving it out of the `need-review` state.
Please, move it back
pulkit added a comment.
In https://phab.mercurial-scm.org/D6356#94599, @sangeet259 wrote:
> @pulkit
>
> > My understanding is that the 1st patch should be present in the mercurial
installed in the system, which is what you said right? If that's correct, we
can go ahead and have this
sangeet259 added a comment.
@pulkit
> My understanding is that the 1st patch should be present in the mercurial
installed in the system, which is what you said right? If that's correct, we
can go ahead and have this whole as one patch as I don't think people usually
do install system
pulkit added a comment.
In https://phab.mercurial-scm.org/D6356#92695, @sangeet259 wrote:
> In https://phab.mercurial-scm.org/D6356#92644, @pulkit wrote:
>
> > > Why do I need to split the patches into two ?
> > > The reason to split what would have been a single patch into two is
pulkit added a comment.
> Patch 1/2
we don't add that to commit messages.
INLINE COMMENTS
> mdiff.py:531
> +
> +def prepare_mdiff(expected, output):
> +"""Prepare the inputs for the mdiff.unidiff function"""
may be worth to rename it to `prepare_mdiff_input`.
> mdiff.py:540
> +
sangeet259 added a subscriber: durin42.
sangeet259 added a comment.
In https://phab.mercurial-scm.org/D6356#92644, @pulkit wrote:
> > Why do I need to split the patches into two ?
> > The reason to split what would have been a single patch into two is
because
> > for the next patch
pulkit added a comment.
> Why do I need to split the patches into two ?
> The reason to split what would have been a single patch into two is because
> for the next patch to be able to use the mdiff during tests,
> this revision has to be there in the system's mercurial installation.
sangeet259 added a comment.
> Oh, nice! I sometimes use run-tests.py -i and just accept an unreadable
diff because I know that hg diff might make it easier to read. I had not
understood why :)
Glad to know you will be helped :)
Added some description to the commit message!
martinvonz added a comment.
In https://phab.mercurial-scm.org/D6356#92453, @sangeet259 wrote:
> In https://phab.mercurial-scm.org/D6356#92451, @martinvonz wrote:
>
> > > The future changes to run-tests.py will enable one to use mdiif
> > > to diff rather than unidiff whenever the
sangeet259 added a comment.
In https://phab.mercurial-scm.org/D6356#92451, @martinvonz wrote:
> > The future changes to run-tests.py will enable one to use mdiif
> > to diff rather than unidiff whenever the mercurial is installed in the
system.
>
> Perhaps a naive question, but
martinvonz added a comment.
> The future changes to run-tests.py will enable one to use mdiif
> to diff rather than unidiff whenever the mercurial is installed in the
system.
Perhaps a naive question, but why is that desirable? How will I (as someone
running tests) notice?
sangeet259 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Patch 1/2
This patch adds some functions to mdiff.py that will be called from
run-tests.py
which will be added in the second part of this patch series.
12 matches
Mail list logo
