This revision was automatically updated to reflect the committed changes.
Closed by commit rHG5d45a997d11d: rebase: remove complex unhiding code
(authored by quark).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D644?vs=1644=1719
REVISION DETAIL
quark added a comment.
In theory things would be fine because fbamend and inhibit is to make things
more visible, not invisible. This patch also makes things from invisible to
visible so they do not conflict.
I have run `./run-tests.py --extra-config-opt=extensions.fbamend=
durham added a comment.
I'd love to get rid of hidden filtering everywhere. Just limit knowledge of
"hidden" to getting the list of visible heads, and algorithms that need to
traverse children.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D644
To: quark,
durham added a comment.
This sound reasonable, assuming all descendant/children computations are done
before prepared is set. Could you run the fb-hgext inhibit/fbamend tests with
this change? Since they might do some more interesting acrobatics around
visibility changes.
REPOSITORY
quark updated this revision to Diff 1644.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D644?vs=1642=1644
REVISION DETAIL
https://phab.mercurial-scm.org/D644
AFFECTED FILES
hgext/rebase.py
CHANGE DETAILS
diff --git a/hgext/rebase.py
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is similar to Martin von Zweigbergk's previous patch [1].
Previous patches are adding more `.unfiltered()` to the rebase code. So I
wonder: are we playing
