This revision was automatically updated to reflect the committed changes.
Closed by commit rHGad55a0a5894f: help: include subtopic in error message if
passed (authored by ngoldbaum, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
ngoldbaum updated this revision to Diff 15269.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6442?vs=15259=15269
REVISION DETAIL
https://phab.mercurial-scm.org/D6442
AFFECTED FILES
mercurial/help.py
tests/test-help.t
CHANGE DETAILS
diff --git
ngoldbaum updated this revision to Diff 15259.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6442?vs=15253=15259
REVISION DETAIL
https://phab.mercurial-scm.org/D6442
AFFECTED FILES
mercurial/help.py
tests/test-help.t
CHANGE DETAILS
diff --git
ngoldbaum updated this revision to Diff 15253.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6442?vs=15247=15253
REVISION DETAIL
https://phab.mercurial-scm.org/D6442
AFFECTED FILES
mercurial/help.py
tests/test-help.t
CHANGE DETAILS
diff --git
ngoldbaum added inline comments.
INLINE COMMENTS
> av6 wrote in help.py:826
> Concatenating things is not the best option when it comes to i18n, but even
> if it were, I think it would make sense to only show here the subtopic, if
> it's provided. If people are curious about internals.foobar
av6 added inline comments.
INLINE COMMENTS
> help.py:826
> +if subtopic:
> +hint += _(" or 'hg help --keyword %s'") % subtopic
> raise error.Abort(msg, hint=hint)
Concatenating things is not the best option when it comes to i18n, but even if
ngoldbaum created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6442
AFFECTED FILES
mercurial/help.py
tests/test-help.t
CHANGE DETAILS
diff --git