durham created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers.
REVISION SUMMARY Previously this check happened in the changegroup code itself. Since it's refactor, this logic needs to move out to callers that care about it, such as this one. Otherwise we get empty bundle devel-warnings in certain extensions. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D690 AFFECTED FILES mercurial/exchange.py CHANGE DETAILS diff --git a/mercurial/exchange.py b/mercurial/exchange.py --- a/mercurial/exchange.py +++ b/mercurial/exchange.py @@ -1632,8 +1632,9 @@ raise ValueError(_('no common changegroup version')) version = max(cgversions) outgoing = _computeoutgoing(repo, heads, common) - cgstream = changegroup.makestream(repo, outgoing, version, source, - bundlecaps=bundlecaps) + if outgoing.missing: + cgstream = changegroup.makestream(repo, outgoing, version, source, + bundlecaps=bundlecaps) if cgstream: part = bundler.newpart('changegroup', data=cgstream) To: durham, #hg-reviewers Cc: mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
