D7685: rebase: use rewriteutil.precheck() instead of reimplementing it

2019-12-18 Thread yuja (Yuya Nishihara)
yuja added a comment. > - hint=_(b'use --keep to keep original changesets'), > - ) > > +if not self.keepf: > +try: > +rewriteutil.precheck(self.repo, rebaseset, action=b'rebase') > +except error.Abort as e: > +if

Re: D7685: rebase: use rewriteutil.precheck() instead of reimplementing it

2019-12-18 Thread Yuya Nishihara
> -hint=_(b'use --keep to keep original changesets'), > -) > +if not self.keepf: > +try: > +rewriteutil.precheck(self.repo, rebaseset, action=b'rebase') > +except error.Abort as e: > +if e.hint is None: > +

D7685: rebase: use rewriteutil.precheck() instead of reimplementing it

2019-12-17 Thread martinvonz (Martin von Zweigbergk)
Closed by commit rHG71fee4564410: rebase: use rewriteutil.precheck() instead of reimplementing it (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7685: rebase: use rewriteutil.precheck() instead of reimplementing it

2019-12-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY After this patch, there's still another place in `rebase.py`, in the `--stop` code path, that reimplements `rewriteutil.precheck()`. I couldn't fix that