D8448: rust-chg: modernize entry function

2020-04-23 Thread yuja (Yuya Nishihara)
Closed by commit rHG9fc9526e283a: rust-chg: modernize entry function (authored by yuja). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE LAST

D8448: rust-chg: modernize entry function

2020-04-22 Thread marmoute (Pierre-Yves David)
Herald added a subscriber: mercurial-patches. marmoute added a comment. In D8448#126114 , @yuja wrote: >> `+ error[E0670]: `async fn` is not permitted in the 2015 edition` > > Appears that we need to specify `--edition=2018`. Sent patch.

D8448: rust-chg: modernize entry function

2020-04-17 Thread yuja (Yuya Nishihara)
yuja added a comment. > `+ error[E0670]: `async fn` is not permitted in the 2015 edition` Appears that we need to specify `--edition=2018`. Sent patch. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8448/new/ REVISION DETAIL

Re: D8448: rust-chg: modernize entry function

2020-04-17 Thread Yuya Nishihara
> `+ error[E0670]: `async fn` is not permitted in the 2015 edition` Appears that we need to specify `--edition=2018`. Sent patch. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

D8448: rust-chg: modernize entry function

2020-04-16 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > main.rs:70 > +#[tokio::main] > +async fn run(umask: u32) -> io::Result { > let mut loc = Locator::prepare_from_env()?; With this series I get lots of `+ error[E0670]: `async fn` is not permitted in the 2015 edition` from

D8448: rust-chg: modernize entry function

2020-04-16 Thread yuja (Yuya Nishihara)
yuja created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Finally the entire build passes. There's a bug that run() no longer waits for the spawned pager, which will be fixed by the next patch. REPOSITORY rHG