This revision was automatically updated to reflect the committed changes.
Closed by commit rHGd817bf1fc675: run-tests: extract Popen logic to a single
method (authored by quark, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
ryanmce accepted this revision.
ryanmce added a comment.
This revision is now accepted and ready to land.
queued
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D948
To: quark, #hg-reviewers, ryanmce
Cc: ryanmce, dlax, mercurial-devel
quark updated this revision to Diff 2889.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D948?vs=2449=2889
REVISION DETAIL
https://phab.mercurial-scm.org/D948
AFFECTED FILES
tests/run-tests.py
CHANGE DETAILS
diff --git a/tests/run-tests.py
ryanmce added inline comments.
INLINE COMMENTS
> ryanmce wrote in run-tests.py:2116
> I can do this in-flight
Actually, since I've asked for changed on the topmost revision, can you fix
this up with the next submission please?
REPOSITORY
rHG Mercurial
REVISION DETAIL
ryanmce added inline comments.
INLINE COMMENTS
> dlax wrote in run-tests.py:2116
> Perhaps also update the indentation of continuation line?
I can do this in-flight
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D948
To: quark, #hg-reviewers
Cc: ryanmce, dlax,
dlax added inline comments.
INLINE COMMENTS
> run-tests.py:2116
> +pread(bisectcmd + ['--good',
>self._runner.options.known_good_rev])
> # TODO: we probably need to forward more options
Perhaps also update the indentation of continuation line?
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This removes 3 lines in total LOC and makes the upcoming changes easier.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D948
AFFECTED
