martinvonz added inline comments.
INLINE COMMENTS
> martinvonz wrote in sparse.py:96
> This can no longer happen. Will you or send a follow-up?
Never mind, I didn't notice it expands the subprofiles and updated the profiles
set in the loop, so the check is necessary.
REPOSITORY
rHG Mercurial
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG32f348d741e5: sparse: use set for capturing profiles
(authored by indygreg).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D95?vs=179&id=220
REVISION DETAIL
ht
martinvonz added inline comments.
INLINE COMMENTS
> sparse.py:96
> profile = profiles.pop()
> if profile in visited:
> continue
This can no longer happen. Will you or send a follow-up?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercuria
dsp accepted this revision.
dsp added a comment.
Looks good! Does it make sense to have a test that codifies that sorting
doesn't matter? e.g. testing that two sparse profiles
//a.sparse//
[include]
[exclude]
x
//b.sparse//
[include]
x
[exclude]
yie
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Order doesn't need to be preserved. A set is acceptable.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D95
AFFECTED FILES
mercuri
