RE: [PATCH 01 of 11] copies: style fixes and add comment (issue4028)

2016-10-07 Thread Gábor STEFANIK
From: timeless.b...@gmail.com [mailto:timeless.b...@gmail.com] On Behalf Of 
timeless
Sent: Wednesday, October 5, 2016 10:57 PM
To: Gábor STEFANIK <gabor.stefa...@nng.com>
Cc: mercurial-devel <mercurial-devel@mercurial-scm.org>
Subject: Re: [PATCH 01 of 11] copies: style fixes and add comment (issue4028)

>> @@ -331,7 +331,8 @@
>>  m2 = c2.manifest()
>>  ma = ca.manifest()
>>
>> -copy1, copy2, = {}, {}
>> +# see checkcopies documentation below for these dicts
>> +copy1, copy2 = {}, {}
>I've been meaning to ask:
>Do we know why this is a -1+2 instead of a -0+1 diff?

Because I've removed a superfluous comma from the 2nd line.



--
This message, including its attachments, is confidential. For more information 
please read NNG's email policy here:
http://www.nng.com/emailpolicy/
By responding to this email you accept the email policy.


___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


Re: [PATCH 01 of 11] copies: style fixes and add comment (issue4028)

2016-10-05 Thread timeless
> @@ -331,7 +331,8 @@
>  m2 = c2.manifest()
>  ma = ca.manifest()
>
> -copy1, copy2, = {}, {}
> +# see checkcopies documentation below for these dicts
> +copy1, copy2 = {}, {}

I've been meaning to ask:
Do we know why this is a -1+2 instead of a -0+1 diff?
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel