Re: stable ordering of test output

2017-04-20 Thread Yuya Nishihara
On Wed, 19 Apr 2017 15:22:42 -0400, Augie Fackler wrote: > On Sat, Apr 15, 2017 at 1:04 PM, Augie Fackler wrote: > > > >> On Apr 15, 2017, at 5:48 AM, Yuya Nishihara wrote: > >> > >> On Thu, 13 Apr 2017 16:17:34 -0400, Augie Fackler wrote: > >>> # HG changeset

Re: stable ordering of test output

2017-04-19 Thread Jun Wu
I'm +1 on this patch. It does not look harmful. Excerpts from Augie Fackler's message of 2017-04-19 15:22:42 -0400: > >> I'm not sure what this condition is intended for. It's always true for > >> write() because r is None and data is a str. > > > > This forwarder is also used for read(), where

Re: stable ordering of test output

2017-04-19 Thread Augie Fackler
On Sat, Apr 15, 2017 at 1:04 PM, Augie Fackler wrote: > >> On Apr 15, 2017, at 5:48 AM, Yuya Nishihara wrote: >> >> On Thu, 13 Apr 2017 16:17:34 -0400, Augie Fackler wrote: >>> # HG changeset patch >>> # User Augie Fackler >>> # Date 1492114180

Re: stable ordering of test output

2017-04-15 Thread Augie Fackler
> On Apr 15, 2017, at 5:48 AM, Yuya Nishihara wrote: > > On Thu, 13 Apr 2017 16:17:34 -0400, Augie Fackler wrote: >> # HG changeset patch >> # User Augie Fackler >> # Date 1492114180 14400 >> # Thu Apr 13 16:09:40 2017 -0400 >> # Node ID

Re: stable ordering of test output

2017-04-15 Thread Yuya Nishihara
On Thu, 13 Apr 2017 16:17:34 -0400, Augie Fackler wrote: > # HG changeset patch > # User Augie Fackler > # Date 1492114180 14400 > # Thu Apr 13 16:09:40 2017 -0400 > # Node ID ec81fd7580f3e31aa92e8834ffbcf2a8e80e72e3 > # Parent 35afb54dbb4df2975dbbf0e1525b98611f18ba85 >

Re: stable ordering of test output

2017-04-13 Thread Matt Harbison
On Thu, 13 Apr 2017 16:17:34 -0400, Augie Fackler wrote: On Thu, Apr 13, 2017 at 3:55 PM, Augie Fackler wrote: On Wed, Mar 8, 2017 at 10:44 AM, Yuya Nishihara wrote: On Tue, 7 Mar 2017 17:56:58 +0100, Pierre-Yves David wrote: On the other

Re: stable ordering of test output

2017-04-13 Thread Danek Duvall
Augie Fackler wrote: > On Thu, Apr 13, 2017 at 3:55 PM, Augie Fackler wrote: > > On Wed, Mar 8, 2017 at 10:44 AM, Yuya Nishihara wrote: > >> On Tue, 7 Mar 2017 17:56:58 +0100, Pierre-Yves David wrote: > >>> On the other hand, this is probably not so bundle2

Re: stable ordering of test output

2017-04-13 Thread Augie Fackler
On Thu, Apr 13, 2017 at 3:55 PM, Augie Fackler wrote: > On Wed, Mar 8, 2017 at 10:44 AM, Yuya Nishihara wrote: >> On Tue, 7 Mar 2017 17:56:58 +0100, Pierre-Yves David wrote: >>> On the other hand, this is probably not so bundle2 specific. We have >>> some

Re: stable ordering of test output

2017-04-13 Thread Augie Fackler
On Wed, Mar 8, 2017 at 10:44 AM, Yuya Nishihara wrote: > On Tue, 7 Mar 2017 17:56:58 +0100, Pierre-Yves David wrote: >> On the other hand, this is probably not so bundle2 specific. We have >> some "select" logic to read stdout and stderr as soon as possible. This >> is the main

Re: stable ordering of test output

2017-03-08 Thread Yuya Nishihara
On Tue, 7 Mar 2017 17:56:58 +0100, Pierre-Yves David wrote: > On the other hand, this is probably not so bundle2 specific. We have > some "select" logic to read stdout and stderr as soon as possible. This > is the main suspect as it is possible that this logic behave different > under linux and

Re: stable ordering of test output

2017-03-07 Thread Matt Harbison
On Fri, 03 Mar 2017 17:45:56 -0500, Danek Duvall wrote: I frequently get failures like this: --- .../mercurial.hg/tests/test-bundle2-exchange.t +++ .../mercurial.hg/tests/test-bundle2-exchange.t.err @@ -1042,11 +1042,11 @@ $ hg --config

Re: stable ordering of test output

2017-03-07 Thread Danek Duvall
Pierre-Yves David wrote: > >>It's also a problem on the FreeBSD buildbot. I don't know enough about > >>the bundle2 code to understand how to fix it, but maybe we can figure > >>out a way to get marmoute an account on a machine taht would help him > >>diagnose? Danek, do you have a solaris

Re: stable ordering of test output

2017-03-07 Thread Pierre-Yves David
On 03/07/2017 05:56 PM, Pierre-Yves David wrote: On 03/07/2017 05:49 PM, Augie Fackler wrote: On Fri, Mar 03, 2017 at 04:37:54PM -0800, Jun Wu wrote: Excerpts from Danek Duvall's message of 2017-03-03 14:45:56 -0800: I frequently get failures like this: ---

Re: stable ordering of test output

2017-03-07 Thread Pierre-Yves David
On 03/07/2017 05:49 PM, Augie Fackler wrote: On Fri, Mar 03, 2017 at 04:37:54PM -0800, Jun Wu wrote: Excerpts from Danek Duvall's message of 2017-03-03 14:45:56 -0800: I frequently get failures like this: --- .../mercurial.hg/tests/test-bundle2-exchange.t +++

Re: stable ordering of test output

2017-03-07 Thread Augie Fackler
On Fri, Mar 03, 2017 at 04:37:54PM -0800, Jun Wu wrote: > Excerpts from Danek Duvall's message of 2017-03-03 14:45:56 -0800: > > I frequently get failures like this: > > > > --- .../mercurial.hg/tests/test-bundle2-exchange.t > > +++ .../mercurial.hg/tests/test-bundle2-exchange.t.err > >

Re: stable ordering of test output

2017-03-03 Thread Jun Wu
Excerpts from Danek Duvall's message of 2017-03-03 14:45:56 -0800: > I frequently get failures like this: > > --- .../mercurial.hg/tests/test-bundle2-exchange.t > +++ .../mercurial.hg/tests/test-bundle2-exchange.t.err > @@ -1042,11 +1042,11 @@ >$ hg --config

stable ordering of test output

2017-03-03 Thread Danek Duvall
I frequently get failures like this: --- .../mercurial.hg/tests/test-bundle2-exchange.t +++ .../mercurial.hg/tests/test-bundle2-exchange.t.err @@ -1042,11 +1042,11 @@ $ hg --config devel.legacy.exchange=bundle1 clone ssh://user@dummy/bundle2onlyserver not-bundle2-ssh