Re: [PATCH 9 of 9] color: drop the now useless color extension

2017-07-17 6:40 GMT+02:00 David Demelier : > And what about our strong backward compatibility? Ignore my mail, I thought having a stale 'color =' in the hgrc would cause an error. I also vote for removal then. Regards, -- Demelier David

Re: [PATCH 1 of 2 V3] commitextras: move fb extension to core which add extras to a commit

On Sat, 15 Jul 2017 01:31:23 +0530, Pulkit Goyal wrote: > # HG changeset patch > # User Pulkit Goyal <7895pul...@gmail.com> > # Date 1499799225 -19800 > # Wed Jul 12 00:23:45 2017 +0530 > # Node ID e51d188da49636884ae6c0df94f501e84436b857 > # Parent 80e1331a7fe970f3e56fde9044949d72d3afdf30 >

Re: Community video chats?

Yep, I'll attend. On 7/15/17 11:02 PM, Phillip Cohen wrote: I'll be on PTO in the mountains then (and I think Durham is in London, but he might still be able to attend), but I hope it goes well (and hopefully somebody takes notes :). On Sat, Jul 15, 2017 at 3:25 AM, Boris Feld

Re: [PATCH 2 of 2 V3] commitextras: check the format of the arguments and no internal key is used

On Sat, 15 Jul 2017 01:31:24 +0530, Pulkit Goyal wrote: > # HG changeset patch > # User Pulkit Goyal <7895pul...@gmail.com> > # Date 1499856010 -19800 > # Wed Jul 12 16:10:10 2017 +0530 > # Node ID 2cbccf36af1bd0d9ae9df1ad5fd4a7f8d870ae6c > # Parent e51d188da49636884ae6c0df94f501e84436b857 >

Re: [PATCH 1 of 2 V3] commitextras: move fb extension to core which add extras to a commit

On Sat, 15 Jul 2017 01:31:23 +0530, Pulkit Goyal wrote: > # HG changeset patch > # User Pulkit Goyal <7895pul...@gmail.com> > # Date 1499799225 -19800 > # Wed Jul 12 00:23:45 2017 +0530 > # Node ID e51d188da49636884ae6c0df94f501e84436b857 > # Parent 80e1331a7fe970f3e56fde9044949d72d3afdf30 >

Re: [PATCH 1 of 2 V3] commitextras: move fb extension to core which add extras to a commit

On Mon, 17 Jul 2017 10:17:38 -0400, Augie Fackler wrote: > On Mon, Jul 17, 2017 at 11:10:02PM +0900, Yuya Nishihara wrote: > > On Sat, 15 Jul 2017 01:31:23 +0530, Pulkit Goyal wrote: > > > # HG changeset patch > > > # User Pulkit Goyal <7895pul...@gmail.com> > > > # Date 1499799225 -19800 > > > #

Re: [PATCH] test-phase-exchange: stabilize for Windows

At Sat, 15 Jul 2017 23:49:54 -0400, Matt Harbison wrote: > > # HG changeset patch > # User Matt Harbison > # Date 1500176793 14400 > # Sat Jul 15 23:46:33 2017 -0400 > # Node ID 21904723f1ce9ea0fc6541ee48611ba3ef7128fb > # Parent

Re: [PATCH v2] run-tests: also color the summary messages (skipped, failed...)

On Sun, 16 Jul 2017 15:12:21 +0900, mlaneuvi...@gmail.com wrote: > # HG changeset patch > # User Matthieu Laneuville > # Date 1500185462 -32400 > # Sun Jul 16 15:11:02 2017 +0900 > # Node ID 9722bfa929b50e7ad87e0561f8d5fdd8e928d755 > # Parent

Re: [PATCH V4] status: add a flag to terse the output (issue4119)

On Fri, Jul 14, 2017 at 12:28:17AM +0530, Pulkit Goyal wrote: > # HG changeset patch > # User Pulkit Goyal <7895pul...@gmail.com> > # Date 1497710422 -19800 > # Sat Jun 17 20:10:22 2017 +0530 > # Node ID d2f046b37522465606f3824d663ece2608f0a23d > # Parent

Re: [PATCH 4 of 4] demandimport: prefer loaded module over package attribute (issue5617)

On Sun, Jul 16, 2017 at 11:41:51PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1500194319 -32400 > # Sun Jul 16 17:38:39 2017 +0900 > # Node ID 6ab37703424f873c658309e9dfcc0ccb311ef655 > # Parent

Re: [PATCH V2] commandserver: do not handle EINTR for selector.select

On Sun, 16 Jul 2017 11:23:40 -0700, Jun Wu wrote: > # HG changeset patch > # User Jun Wu > # Date 1500229020 25200 > # Sun Jul 16 11:17:00 2017 -0700 > # Node ID 3fce51f52763323f1ff2e233e44aa926c2095d05 > # Parent d09de637cbc88ed2db989298115d0c0cb6cc6f27 > # Available At

Re: [PATCH 1 of 2] archive: use a templater to build the metadata file

On Mon, 17 Jul 2017 00:57:38 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1500241236 14400 > # Sun Jul 16 17:40:36 2017 -0400 > # Node ID 4d37def90ad5e0196dadb9bc2c9e62effad63691 > # Parent

Re: [PATCH v3] releasenotes: add custom admonitions support for release notes

On Sun, 16 Jul 2017 11:58:28 -0400, Augie Fackler wrote: > > > On Jul 16, 2017, at 10:30 AM, Yuya Nishihara wrote: > > > > On Sun, 16 Jul 2017 14:25:28 +0200, Rishabh Madan wrote: > >> On Sun, Jul 16, 2017 at 2:20 PM, Rishabh Madan > >> wrote: > >>> On

Re: [PATCH 2 of 3] transaction-summary: display the summary for all transactions

On Sun, Jul 16, 2017 at 11:21:42AM +0200, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1500164406 -7200 > # Sun Jul 16 02:20:06 2017 +0200 > # Node ID 8df908eb63b41ebef19e71f4f3f0085be4e6f8b3 > # Parent

Re: [PATCH 9 of 9] color: drop the now useless color extension

On Sun, Jul 16, 2017 at 03:27:31PM -0700, Sean Farley wrote: > > Boris Feld writes: > > > # HG changeset patch > > # User Boris Feld > > # Date 1500121055 -7200 > > # Sat Jul 15 14:17:35 2017 +0200 > > # Node ID

Re: [PATCH 8 of 8] share: share 'cachevfs' with the source clone (issue5108)

On Sun, Jul 16, 2017 at 10:47:53AM +0200, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1500155362 -7200 > # Sat Jul 15 23:49:22 2017 +0200 > # Node ID 18baeb5c7d7358d87097fbee9b5b370ff4a55f76 > # Parent

Re: [PATCH v2] run-tests: also color the summary messages (skipped, failed...)

On Sun, Jul 16, 2017 at 03:12:21PM +0900, mlaneuvi...@gmail.com wrote: > # HG changeset patch > # User Matthieu Laneuville > # Date 1500185462 -32400 > # Sun Jul 16 15:11:02 2017 +0900 > # Node ID 9722bfa929b50e7ad87e0561f8d5fdd8e928d755 > # Parent

Re: [PATCH] run-tests: make sure to check if pygments is installed before using it

On Sat, Jul 15, 2017 at 02:35:28AM +0530, Pulkit Goyal wrote: > # HG changeset patch > # User Pulkit Goyal <7895pul...@gmail.com> > # Date 1500065225 -19800 > # Sat Jul 15 02:17:05 2017 +0530 > # Node ID 07928a5240e51e2cd44f7e05fccda32053ee0133 > # Parent

Re: Potential BC changes to sparse before freeze

> On Jul 17, 2017, at 12:57, Gregory Szorc wrote: > > > >> On Jul 11, 2017, at 11:01, Gregory Szorc wrote: >> >> Durham, et al: >> >> 4.3 freeze is in a few days. While we have declared sparse as an >> experimental feature and not subject

Re: Experimenting with Phabricator for reviews

> On Jul 15, 2017, at 11:42, Augie Fackler wrote: > >> On Jul 14, 2017, at 7:30 PM, Sean Farley wrote: >> >> Jun Wu writes: >> >>> Excerpts from Sean Farley's message of 2017-07-14 16:26:34 -0700: Huh? But that's the thing, isn't it?

Re: [Differential] D107: util: remove dead code which used to be for old python2 versions

alex_gaynor created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D107 AFFECTED FILES mercurial/util.py CHANGE DETAILS Index: mercurial/util.py

Re: Potential BC changes to sparse before freeze

> On Jul 11, 2017, at 11:01, Gregory Szorc wrote: > > Durham, et al: > > 4.3 freeze is in a few days. While we have declared sparse as an experimental > feature and not subject to BC, shipping in 4.3 means someone will inevitably > use it and be impacted by future

Re: [Differential] D107: util: remove dead code which used to be for old python2 versions

indygreg added a comment. It's worth noting that in theory it should be possible to transition from buffer to memoryview. However, there are various bugs in various Python 2 versions where memoryview isn't accepted. Most notable is that the zlib module doesn't accept memoryview until Python

Re: Potential BC changes to sparse before freeze

> On Jul 17, 2017, at 07:10, Augie Fackler wrote: > >> On Sat, Jul 15, 2017 at 03:15:08PM -0700, Sean Farley wrote: >> >> Gregory Szorc writes: >> On Sat, Jul 15, 2017 at 1:28 PM, Sean Farley wrote: Martin von

Re: [PATCH 2 of 3] transaction-summary: display the summary for all transactions

On Sun, Jul 16, 2017 at 2:21 AM, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1500164406 -7200 > # Sun Jul 16 02:20:06 2017 +0200 > # Node ID 8df908eb63b41ebef19e71f4f3f0085be4e6f8b3 > # Parent

Re: [Differential] D107: util: remove dead code which used to be for old python2 versions

alex_gaynor added a comment. @indygreg good flag, @durin42 and I had been discussing the "always use `memoryview`" as a potential follow up patch. For now this just deletes some dead code. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D107 EMAIL

Re: Potential BC changes to sparse before freeze

On Mon, Jul 17, 2017 at 8:58 AM, Gregory Szorc wrote: > > >> On Jul 17, 2017, at 07:10, Augie Fackler wrote: >> >>> On Sat, Jul 15, 2017 at 03:15:08PM -0700, Sean Farley wrote: >>> >>> Gregory Szorc writes: >>> > On Sat,

Re: Potential BC changes to sparse before freeze

On Mon, Jul 17, 2017 at 9:57 AM, Gregory Szorc wrote: > > >> On Jul 11, 2017, at 11:01, Gregory Szorc wrote: >> >> Durham, et al: >> >> 4.3 freeze is in a few days. While we have declared sparse as an >> experimental feature and not subject to

Re: D107: util: remove dead code which used to be for old python2 versions

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9a2ee9591acc: util: remove dead code which used to be for old python2 versions (authored by alex_gaynor). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: [PATCH 9 of 9] color: drop the now useless color extension

Augie Fackler writes: > On Sun, Jul 16, 2017 at 03:27:31PM -0700, Sean Farley wrote: >> >> Boris Feld writes: >> >> > # HG changeset patch >> > # User Boris Feld >> > # Date 1500121055 -7200 >> > # Sat Jul 15 14:17:35 2017

Re: D38: phabricator: allow specifying reviewers on phabsend

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb7a75b9a3386: phabricator: allow specifying reviewers on phabsend (authored by quark). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D38?vs=54=207 REVISION

Re: D59: sparse: override dirstate.walk() instead of dirstate._ignore

This revision was automatically updated to reflect the committed changes. Closed by commit rHG258298f4712b: sparse: override dirstate.walk() instead of dirstate._ignore (authored by martinvonz). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D59?vs=77=206

Re: D60: match: remove unused negatematcher

This revision was automatically updated to reflect the committed changes. Closed by commit rHG80e1331a7fe9: match: remove unused negatematcher (authored by martinvonz). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D60?vs=130=205 REVISION DETAIL

Re: [PATCH 2 of 2] archive: add an experimental config to control the metadata file template

On Sun, Jul 16, 2017 at 9:57 PM, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1500266969 14400 > # Mon Jul 17 00:49:29 2017 -0400 > # Node ID a85b7c754630cb4ac49b2cebea0ceca3d2f2eaaa > # Parent

[PATCH] win32: copy-edit debugssl messages to match prevailing style

# HG changeset patch # User Kevin Bullock # Date 1500315779 18000 # Mon Jul 17 13:22:59 2017 -0500 # Node ID dcd0c87ef9e443e612e3b7eb4e1d7406df9549be # Parent 9a2ee9591acc4d5f5ab6bbb7054cb62cb5f29a62 win32: copy-edit debugssl messages to match prevailing

[PATCH resend] run-tests: make sure to check if pygments is installed before using it

# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1500065225 -19800 # Sat Jul 15 02:17:05 2017 +0530 # Node ID 37df34ca705cf68eef4fa6b4087eb039f775d4e6 # Parent 0353c051d54702a960e4efba1eea6fbc13ad401a run-tests: make sure to check if pygments is installed before using

mercurial@33549: 58 new changesets

58 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/14af04391fb9 changeset: 33492:14af04391fb9 user:Matt Harbison date:Wed Mar 29 23:45:23 2017 -0400 summary: win32: add a method to trigger the Crypto API to complete a

Re: D109: sparse: consolidate common code for writing sparse config

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In 3 functions we were writing the sparse config and updating the working directory. In two of them we had a transaction-like process for restoring the sparse

Re: D110: sparse: add a requirement when a repository uses sparse (BC)

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The presence of a sparse checkout can confuse legacy clients or clients without sparse enabled for reasons that should be obvious. This commit introduces a

Re: [PATCH] win32: copy-edit debugssl messages to match prevailing style

Looks an easy win to me. Excerpts from Kevin Bullock's message of 2017-07-17 13:23:55 -0500: > # HG changeset patch > # User Kevin Bullock > # Date 1500315779 18000 > # Mon Jul 17 13:22:59 2017 -0500 > # Node ID dcd0c87ef9e443e612e3b7eb4e1d7406df9549be > #

Re: [PATCH resend] run-tests: make sure to check if pygments is installed before using it

LGTM. Excerpts from Pulkit Goyal's message of 2017-07-18 00:07:32 +0530: > # HG changeset patch > # User Pulkit Goyal <7895pul...@gmail.com> > # Date 1500065225 -19800 > # Sat Jul 15 02:17:05 2017 +0530 > # Node ID 37df34ca705cf68eef4fa6b4087eb039f775d4e6 > # Parent

Re: [PATCH] run-tests: make sure to check if pygments is installed before using it

On Sun, Jul 16, 2017 at 02:07:03PM +0900, mlaneuvi...@gmail.com wrote: > # HG changeset patch > # User Matthieu Laneuville > # Date 1500181438 -32400 > # Sun Jul 16 14:03:58 2017 +0900 > # Node ID 97ec8637d261a97c30944d9242ee1ccdbf536cb3 > # Parent

Re: [PATCH] win32: copy-edit debugssl messages to match prevailing style

On Mon, Jul 17, 2017 at 12:22:45PM -0700, Jun Wu wrote: > Looks an easy win to me. queued, thanks > > Excerpts from Kevin Bullock's message of 2017-07-17 13:23:55 -0500: > > # HG changeset patch > > # User Kevin Bullock > > # Date 1500315779 18000 > > #

Re: D97: revset: pass repo when passing ui

durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. Taking this one, but going to punt on https://phab.mercurial-scm.org/D98 per the "consider this an RFC" comment I saw. REPOSITORY rHG Mercurial REVISION DETAIL

[PATCH] run-tests: check if stream is a tty before using color

# HG changeset patch # User Matthieu Laneuville # Date 1500329966 -32400 # Tue Jul 18 07:19:26 2017 +0900 # Node ID 7f5f97697162331b5acf78aef091ae3fd341e308 # Parent 9b2647a7a70a270e85457ea55583b6eba0551258 run-tests: check if stream is a tty before using

Re: D110: sparse: add a requirement when a repository uses sparse (BC)

martinvonz added inline comments. INLINE COMMENTS > indygreg wrote in sparse.py:526 > Yes, it would be cleaner to have a dedicated function to turn off sparse. > Yes, it would unlink .hg/sparse. I was being a bit lazy when I wrote this > patch because I wanted to get something in before the

Re: D116: run-tests: check pygmentspresent in parseargs()

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Checking earlier if it's installed means we can remove the check later. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D116

Re: D114: run-tests: pass color option via options object, not global var

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There are already other attributes on the options object that are not directly outputs from command line parsing, so this doesn't seem too bad to me.

Re: [PATCH] test-phase-exchange: stabilize for Windows

On Mon, 17 Jul 2017 11:05:27 -0400, FUJIWARA Katsunori wrote: At Sat, 15 Jul 2017 23:49:54 -0400, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1500176793 14400 # Sat Jul 15 23:46:33 2017 -0400 # Node ID

Re: D121: phabricator: use Phabricator's last node information

quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This makes it more strict when checking whether or not we should update a Differential Revision. For example, a) Alice updates D1 to content 1. b) Bob

Re: D120: phabricator: add --status option to phabread

quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The --status option filters Differential Revisions by their status, like "Opened", "Accetped" etc. It could be useful to skip certain revisions. REPOSITORY rHG

Re: D118: run-tests: remove unnecessary 'with_color' variable

quark added inline comments. INLINE COMMENTS > run-tests.py:424 > sys.stderr.write('warning: --color=always ignored because' > - 'pygments is not installed\n') > + 'pygment is not installed\n') > Seems like a wrong

Re: [PATCH 2 of 2] archive: add an experimental config to control the metadata file template

On Mon, 17 Jul 2017 13:54:29 -0400, Martin von Zweigbergk wrote: On Sun, Jul 16, 2017 at 9:57 PM, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1500266969 14400 # Mon Jul 17 00:49:29 2017

Re: D118: run-tests: remove unnecessary 'with_color' variable

martinvonz updated this revision to Diff 234. martinvonz marked an inline comment as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D118?vs=229=234 REVISION DETAIL https://phab.mercurial-scm.org/D118 AFFECTED FILES tests/run-tests.py CHANGE

Re: D118: run-tests: remove unnecessary 'with_color' variable

martinvonz added inline comments. INLINE COMMENTS > quark wrote in run-tests.py:424 > Seems like a wrong spellchecker? Oops, thanks for spotting that. It was a rebase artifact. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D118 EMAIL PREFERENCES

Re: D113: gitweb: preserve whitespace in description

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Without this, multiple spaces or tabs in the commit message aren't preserved and things like tables don't align properly. As part of adding the CSS rule, we

Re: [PATCH 1 of 2] archive: use a templater to build the metadata file

On Mon, 17 Jul 2017 09:53:12 -0400, Yuya Nishihara wrote: On Mon, 17 Jul 2017 00:57:38 -0400, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1500241236 14400 # Sun Jul 16 17:40:36 2017 -0400 # Node ID

[PATCH v3] run-tests: make sure to check if pygments is installed before using it

# HG changeset patch # User Matthieu Laneuville # Date 1500181438 -32400 # Sun Jul 16 14:03:58 2017 +0900 # Node ID 6254e8515425dd54f6200a6231f2d45f86d5a060 # Parent 389536aff376d32d38f13305021c127245d4126a run-tests: make sure to check if pygments is

Re: D117: run-tests: warn if --color=always and no pygments installed

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D117 AFFECTED FILES tests/run-tests.py CHANGE DETAILS diff --git a/tests/run-tests.py

Re: D118: run-tests: remove unnecessary 'with_color' variable

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Its value is always the same as that of 'pygmentspresent'. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D118 AFFECTED FILES

Re: D115: run-tests: move check isatty() check for color inside parseargs()

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This will help with removing the global variables by making sure 'pygmentspresent' always has the same value as 'with_color'. REPOSITORY rHG Mercurial

Re: D119: color: add autoterminfo option to prefer terminfo over ansi for non-windows

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY If color.mode=auto in the config (this is the default) then color.py currently checks if using windows, and if not, uses 'ansi'. This means that to get

[PATCH] templates: add substring and string length operations

# HG changeset patch # User Rodrigo Damazio Bovendorp # Date 1500072378 25200 # Fri Jul 14 15:46:18 2017 -0700 # Node ID 0ccebbd04efbd672fc71df7f52ec243057cbed7d # Parent c0d8de2724ce6240d2a4241aff78ce2ee92359c2 templates: add substring and string length operations

mercurial@33551: 2 new changesets

2 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/32f348d741e5 changeset: 33550:32f348d741e5 user:Gregory Szorc date:Sat Jul 15 13:07:57 2017 -0700 summary: sparse: use set for capturing profiles

Re: [PATCH 2 of 2] archive: add an experimental config to control the metadata file template

On Mon, 17 Jul 2017 09:56:25 -0400, Yuya Nishihara wrote: On Mon, 17 Jul 2017 00:57:39 -0400, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1500266969 14400 # Mon Jul 17 00:49:29 2017 -0400 # Node ID

Re: D95: sparse: use set for capturing profiles

martinvonz added inline comments. INLINE COMMENTS > martinvonz wrote in sparse.py:96 > This can no longer happen. Will you or send a follow-up? Never mind, I didn't notice it expands the subprofiles and updated the profiles set in the loop, so the check is necessary. REPOSITORY rHG

Re: D110: sparse: add a requirement when a repository uses sparse (BC)

indygreg added inline comments. INLINE COMMENTS > martinvonz wrote in sparse.py:526 > It feels like this would be clearer as two method: the old one and a new one > that just turns sparse off. That would ideally unlink .hg/sparse, no? The new > method would not accept includes, excludes, or

Re: D96: sparse: require [section] in sparse config files (BC)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG1d1779734c99: sparse: require [section] in sparse config files (BC) (authored by indygreg). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D96?vs=180=221

Re: D95: sparse: use set for capturing profiles

This revision was automatically updated to reflect the committed changes. Closed by commit rHG32f348d741e5: sparse: use set for capturing profiles (authored by indygreg). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D95?vs=179=220 REVISION DETAIL

Re: [PATCH resend] run-tests: make sure to check if pygments is installed before using it

On Mon, Jul 17, 2017 at 1:07 PM, Augie Fackler wrote: > On Mon, Jul 17, 2017 at 12:24:26PM -0700, Jun Wu wrote: >> LGTM. > > Queued, thanks. > >> >> Excerpts from Pulkit Goyal's message of 2017-07-18 00:07:32 +0530: >> > # HG changeset patch >> > # User Pulkit Goyal

Re: [PATCH v3] run-tests: make sure to check if pygments is installed before using it

Pulkit's fix was just queued [1]. You might want to follow the hg-committed repo to get the latest before sending patches. [1]: https://www.mercurial-scm.org/repo/hg-committed/rev/754569f5e999 Excerpts from mlaneuville's message of 2017-07-18 07:08:49 +0900: > # HG changeset patch > # User

Re: D95: sparse: use set for capturing profiles

martinvonz added inline comments. INLINE COMMENTS > sparse.py:96 > profile = profiles.pop() > if profile in visited: > continue This can no longer happen. Will you or send a follow-up? REPOSITORY rHG Mercurial REVISION DETAIL

[PATCH v2] templates: add substring and string length operations

# HG changeset patch # User Rodrigo Damazio Bovendorp # Date 1500075683 25200 # Fri Jul 14 16:41:23 2017 -0700 # Node ID c4bac4ea7b1ea923d6ba4299cd9c974469b39cb0 # Parent c0d8de2724ce6240d2a4241aff78ce2ee92359c2 templates: add substring and string length operations

Re: D110: sparse: add a requirement when a repository uses sparse (BC)

martinvonz added inline comments. INLINE COMMENTS > sparse.py:526 > def _updateconfigandrefreshwdir(repo, includes, excludes, profiles, > -force=False): > +force=False, removing=False): > """Update the sparse config and