D737: directaccess: add support for accessing hidden commits if command is read only

2017-09-19 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch adds support for accessing hidden commits by read only commands. It introduces a new config experimental.directaccess which can be set to true to

D736: directaccess: add support for storing the type of command in func object

2017-09-19 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch adds support for storing the type of command which is going to run in the func object. For this it does the following: 1. Add three possible

D738: directaccess: add support to export and tests to demonstrate things

2017-09-19 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch adds the cmdtype attribute to export command which is a read only command and adds test for accessing hidden commits using the same command. REPOSITORY

Re: [PATCH 6 of 6] tests: avoid repr in test-bundle2-format.t

2017-09-19 Thread Pulkit Goyal
The series looks good to me. On Tue, Sep 19, 2017 at 9:38 PM, Augie Fackler wrote: > # HG changeset patch > # User Augie Fackler > # Date 1505758787 14400 > # Mon Sep 18 14:19:47 2017 -0400 > # Node ID eef6eaa44b13c7d8f3802776586d119f1dfb33f7 > # Parent

D614: registrar: make cmdtype an attribute of the function in registar.command

2017-09-19 Thread pulkit (Pulkit Goyal)
pulkit abandoned this revision. pulkit added a comment. Send as https://phab.mercurial-scm.org/D736, https://phab.mercurial-scm.org/D737 and https://phab.mercurial-scm.org/D738. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D614 To: pulkit, #hg-reviewers,

D696: registrar: add a enum 'cmdtype' for the type of the command

2017-09-19 Thread pulkit (Pulkit Goyal)
pulkit abandoned this revision. pulkit added a comment. Send the series as https://phab.mercurial-scm.org/D736, https://phab.mercurial-scm.org/D737 and https://phab.mercurial-scm.org/D738. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D696 To: pulkit,

D740: tersestatus: sort the dictionary before iterating on it

2017-09-19 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There has report of flakiness in test-status-terse.t. In the terse code, we are iterating on a dictionary without sorting and since python dicts are unordered,

D612: command: add a cmdtype argument to registrar.command

2017-09-19 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Resend the series as https://phab.mercurial-scm.org/D736, https://phab.mercurial-scm.org/D737 and https://phab.mercurial-scm.org/D738. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D612 To: pulkit, #hg-reviewers, durham Cc: quark,

D734: uncommit: don't allow bare uncommit on dirty working directory

2017-09-19 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As per IRC discussion and suggestion by Augie, we should not allow bare `hg uncommit` on dirty working directory. REPOSITORY rHG Mercurial REVISION DETAIL

D735: uncommit: add an experimental.uncommitondirtywdir config

2017-09-19 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There are people who wants to do `hg uncommit` on dirty working directory, so this patch adds a config which can be used to the achieve that. Adds tests for

D680: scmutil: handle conflicting files and dirs in origbackuppath

2017-09-19 Thread mbthomas (Mark Thomas)
mbthomas marked 2 inline comments as done. mbthomas added inline comments. INLINE COMMENTS > yuja wrote in scmutil.py:570 > Perhaps fullorigpath may be a Windows path, but util.finddirs() > can only handle internal path. I've changed it to use `util.normpath`, which I think converts back to `/`

D680: scmutil: handle conflicting files and dirs in origbackuppath

2017-09-19 Thread mbthomas (Mark Thomas)
mbthomas updated this revision to Diff 1894. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D680?vs=1893=1894 REVISION DETAIL https://phab.mercurial-scm.org/D680 AFFECTED FILES mercurial/scmutil.py tests/test-origbackup-conflict.t CHANGE DETAILS

D680: scmutil: handle conflicting files and dirs in origbackuppath

2017-09-19 Thread mbthomas (Mark Thomas)
mbthomas updated this revision to Diff 1892. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D680?vs=1721=1892 REVISION DETAIL https://phab.mercurial-scm.org/D680 AFFECTED FILES mercurial/scmutil.py tests/test-origbackup-conflict.t CHANGE DETAILS

D680: scmutil: handle conflicting files and dirs in origbackuppath

2017-09-19 Thread mbthomas (Mark Thomas)
mbthomas updated this revision to Diff 1893. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D680?vs=1892=1893 REVISION DETAIL https://phab.mercurial-scm.org/D680 AFFECTED FILES mercurial/scmutil.py tests/test-origbackup-conflict.t CHANGE DETAILS

[PATCH 1 of 6 v2] util: add platform-agnostic absjoin function and some long-paths win utils

2017-09-19 Thread Kostia Balytskyi
# HG changeset patch # User Kostia Balytskyi # Date 1505835722 25200 # Tue Sep 19 08:42:02 2017 -0700 # Node ID 280ac0656c0637d1006b956cfe4b21808ff0207c # Parent 2844c4bd5a398aaa78114d02f6a6a876898cb910 util: add platform-agnostic absjoin function and some long-paths win

D680: scmutil: handle conflicting files and dirs in origbackuppath

2017-09-19 Thread ikostia (Kostia Balytskyi)
ikostia added a comment. Here's a patch: https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-September/104837.html REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D680 To: mbthomas, ryanmce, #hg-reviewers, durham, yuja, ikostia Cc: ikostia, yuja,

D656: revset: remove "small" argument from "_optimize"

2017-09-19 Thread quark (Jun Wu)
quark added a comment. In https://phab.mercurial-scm.org/D656#12304, @yuja wrote: > (copied from the email thread) I saw your email (and the next one). The commit message was updated accordingly. I think Phabricator in-bound email now works as long as the "From" address is knwon

[PATCH 4 of 6 v2] windows: add relpath which knows about \\?\ prefix

2017-09-19 Thread Kostia Balytskyi
# HG changeset patch # User Kostia Balytskyi # Date 1505837708 25200 # Tue Sep 19 09:15:08 2017 -0700 # Node ID 59578c527e95704396e04e77435cbab6a966 # Parent 3294e39ad1c3adf26308eae859280437f1671220 windows: add relpath which knows about \\?\ prefix We want to correctly

[PATCH 3 of 6 v2] dirstate: make dirstate._join a bit faster on posix

2017-09-19 Thread Kostia Balytskyi
# HG changeset patch # User Kostia Balytskyi # Date 1505837513 25200 # Tue Sep 19 09:11:53 2017 -0700 # Node ID 3294e39ad1c3adf26308eae859280437f1671220 # Parent db7c6d368422041bb0d5ff5dafcd4cdaf3943fac dirstate: make dirstate._join a bit faster on posix This is a

[PATCH 5 of 6 v2] run_tests: know how to match Windows //?/C:\Something paths

2017-09-19 Thread Kostia Balytskyi
# HG changeset patch # User Kostia Balytskyi # Date 1505837708 25200 # Tue Sep 19 09:15:08 2017 -0700 # Node ID 29007a29700f107b7fd5bf139fa192f9528d6349 # Parent 59578c527e95704396e04e77435cbab6a966 run_tests: know how to match Windows //?/C:\Something paths diff --git

[PATCH 6 of 6 v2] paths: allow util.finddirs touse os.path.sep

2017-09-19 Thread Kostia Balytskyi
# HG changeset patch # User Kostia Balytskyi # Date 1505837708 25200 # Tue Sep 19 09:15:08 2017 -0700 # Node ID 0a561e2299b6880dd0e6e91294c92bbc0aef726b # Parent 29007a29700f107b7fd5bf139fa192f9528d6349 paths: allow util.finddirs touse os.path.sep diff --git

[PATCH 2 of 6 v2] windows: teach dirstate and posixfile to understand long paths

2017-09-19 Thread Kostia Balytskyi
# HG changeset patch # User Kostia Balytskyi # Date 1505835722 25200 # Tue Sep 19 08:42:02 2017 -0700 # Node ID db7c6d368422041bb0d5ff5dafcd4cdaf3943fac # Parent 280ac0656c0637d1006b956cfe4b21808ff0207c windows: teach dirstate and posixfile to understand long paths diff

D730: revlog: add revmap back to revlog.addgroup

2017-09-19 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. > A previous patch removed the revmap argument from addgroup s/A previous patch/The recent https://phab.mercurial-scm.org/rHGc8b6ed51386bf7dbcc746d5ac2835c38937a9e26/ to make it easier for others s/revmap/linkmapper/ > The fix is to return

[PATCH 4 of 6] bundle2: portably grab first byte of part name for letter check

2017-09-19 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1505795275 14400 # Tue Sep 19 00:27:55 2017 -0400 # Node ID 8def3a241d2298eb47bebb19f70ec8d4c1341739 # Parent b4cb774af1c9da914c81e8bf42988828f9807b61 bundle2: portably grab first byte of part name for letter check diff

[PATCH 1 of 6] bundle2: stop using %r to quote part names

2017-09-19 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1505756143 14400 # Mon Sep 18 13:35:43 2017 -0400 # Node ID d3ecff8a8e1e49438fb7027adb12b678f394ff11 # Parent a254c669b47549ba9056a1a3180a918c4a4eae80 bundle2: stop using %r to quote part names Valid part names are

[PATCH 5 of 6] tests: port test-bundle2-format inline helper script to Python 3

2017-09-19 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1505757845 14400 # Mon Sep 18 14:04:05 2017 -0400 # Node ID df919997998c3a6fa3f3182a84a7d13011a58ed9 # Parent 8def3a241d2298eb47bebb19f70ec8d4c1341739 tests: port test-bundle2-format inline helper script to Python 3 We're

[PATCH 6 of 6] tests: avoid repr in test-bundle2-format.t

2017-09-19 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1505758787 14400 # Mon Sep 18 14:19:47 2017 -0400 # Node ID eef6eaa44b13c7d8f3802776586d119f1dfb33f7 # Parent df919997998c3a6fa3f3182a84a7d13011a58ed9 tests: avoid repr in test-bundle2-format.t We don't *really* need it

[PATCH 2 of 6] bundle2: update check for a generator to work on Python 3

2017-09-19 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1505756165 14400 # Mon Sep 18 13:36:05 2017 -0400 # Node ID 43d20140917917f63e9b1d030847260fdf637d8b # Parent d3ecff8a8e1e49438fb7027adb12b678f394ff11 bundle2: update check for a generator to work on Python 3 diff --git

[PATCH 3 of 6] bundle2: make ValueError messages native strings

2017-09-19 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1505757801 14400 # Mon Sep 18 14:03:21 2017 -0400 # Node ID b4cb774af1c9da914c81e8bf42988828f9807b61 # Parent 43d20140917917f63e9b1d030847260fdf637d8b bundle2: make ValueError messages native strings diff --git

D656: revset: remove "small" argument from "_optimize"

2017-09-19 Thread yuja (Yuya Nishihara)
yuja accepted this revision. yuja added a comment. This revision is now accepted and ready to land. Queued, thanks. (copied from the email thread) On Fri, 8 Sep 2017 17:06:12 +, quark (Jun Wu) wrote: >> yuja wrote in revsetlang.py:421 > > Any reason to choose 1 here and

D657: revset: move weight information to predicate

2017-09-19 Thread yuja (Yuya Nishihara)
yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. (copied from the email thread, though I'm okay with the latest patch.) On Fri, 8 Sep 2017 18:24:44 +, phillco (Phil Cohen) wrote: > phillco added a comment. > >

Re: [PATCH 1 of 8] tests: fix run-tests default values in Test constructor

2017-09-19 Thread Yuya Nishihara
On Tue, 19 Sep 2017 00:35:18 -0400, Augie Fackler wrote: > # HG changeset patch > # User Augie Fackler > # Date 1505794017 14400 > # Tue Sep 19 00:06:57 2017 -0400 > # Node ID 920c56d5f84cd54395a22cce9d0cc79216ed4cf2 > # Parent 1533371769b5ad3de2c7aa1ed08ee7cfb99c0c91 >

robots.txt for www.mercurial-scm.org

2017-09-19 Thread Michael Bolin
It appears that https://www.mercurial-scm.org/robots.txt disallows indexing of /repo. This makes it impossible to Google for Mercurial commits. Is this an oversight or is it intentional? ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

D654: blackbox: unindent a try block

2017-09-19 Thread quark (Jun Wu)
quark added a comment. Sorry, did a wrong merge resolution. Will fix soon. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D654 To: quark, #hg-reviewers, durham, yuja Cc: yuja, mercurial-devel ___ Mercurial-devel

D654: blackbox: unindent a try block

2017-09-19 Thread yuja (Yuya Nishihara)
yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. This look like doing more than "unindent a try block". INLINE COMMENTS > blackbox.py:153 > +changed = '' > +if ui._bbrepo: > +ctx =

D680: scmutil: handle conflicting files and dirs in origbackuppath

2017-09-19 Thread yuja (Yuya Nishihara)
yuja added inline comments. INLINE COMMENTS > mbthomas wrote in scmutil.py:570 > I've changed it to use `util.normpath`, which I think converts back to `/` as > separator on windows (`windows.normpath` calls `windows.pconvert`), and is > probably a good idea anyway. Is this sufficient?

D680: scmutil: handle conflicting files and dirs in origbackuppath

2017-09-19 Thread ryanmce (Ryan McElroy)
ryanmce added a subscriber: ikostia. ryanmce added a comment. Calling in windows path expert @ikostia REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D680 To: mbthomas, ryanmce, #hg-reviewers, durham, yuja Cc: ikostia, yuja, durham, mercurial-devel

D652: blackbox: simplify ui states

2017-09-19 Thread yuja (Yuya Nishihara)
yuja accepted this revision. yuja added a comment. This revision is now accepted and ready to land. Looks good. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D652 To: quark, #hg-reviewers, durham, yuja Cc: yuja, mercurial-devel

D680: scmutil: handle conflicting files and dirs in origbackuppath

2017-09-19 Thread ikostia (Kostia Balytskyi)
ikostia requested changes to this revision. ikostia added a comment. This revision now requires changes to proceed. Please wait until the `util.finddirs()` is tweaked and remove `normpath` call. INLINE COMMENTS > yuja wrote in scmutil.py:570 > That's probably okay now. > > I'm not sure if

D657: revset: move weight information to predicate

2017-09-19 Thread quark (Jun Wu)
quark updated this revision to Diff 1896. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D657?vs=1895=1896 REVISION DETAIL https://phab.mercurial-scm.org/D657 AFFECTED FILES mercurial/registrar.py mercurial/revset.py mercurial/revsetlang.py

D655: blackbox: set lastui even if ui.log is not called (issue5518)

2017-09-19 Thread quark (Jun Wu)
quark updated this revision to Diff 1898. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D655?vs=1880=1898 REVISION DETAIL https://phab.mercurial-scm.org/D655 AFFECTED FILES hgext/blackbox.py tests/test-blackbox.t CHANGE DETAILS diff --git

D654: blackbox: unindent a try block

2017-09-19 Thread quark (Jun Wu)
quark updated this revision to Diff 1897. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D654?vs=1879=1897 REVISION DETAIL https://phab.mercurial-scm.org/D654 AFFECTED FILES hgext/blackbox.py CHANGE DETAILS diff --git a/hgext/blackbox.py