dlax requested changes to this revision.
dlax added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> commands.py:1048
> scmutil.checknewlabel(repo, label, 'branch')
> -repo.dirstate.setbranch(label)
> -ui.status(_('marked
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa652b7763f66: peer: when collecting method names for batch
calls, bytes-ify __name__ (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG95be8928d6b2: hgweb: fill in content-type and
content-length as native strings (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG9c3dcaf648ef: httppeer: convert request url back to bytes
before inspecting it (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG01206460897a: server: indent block thats about to get
conditionalized (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG60e7da55e5e6: hgweb: set sent_headers attr as early as
practical (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6e1b05692b2c: hgweb: detect Python 3-era libraries and use
modern attribute names (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
dlax added inline comments.
INLINE COMMENTS
> cmdutil.py:749
> +if len(heads) < 1:
> +raise error.Abort(_("cannot change branch in betwen the stack"))
> +
typo: betwen
Also, I'm not sure "between" is appropriate here. Maybe "cannot change branch
in the middle of a stack"?
>
dlax added inline comments.
INLINE COMMENTS
> split.py:53
> +
> +Repetitively prompt changes and commit message for new changesets until
> +there is nothing left in the original changeset.
Not sure "repetitively" exists. Maybe "repeatedly"?
REPOSITORY
rHG Mercurial
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGdaf12f69699f: python3: replace im_{self,func} with
__{self,func}__ globally (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGbaee5512f262: hgweb: mimetype guessing needs a unicode path
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb13c95919ff5: templater: explode if we try to emit a str
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1088?vs=2768=2778
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa288712d86d5: httppeer: extract content-type from headers
using native str (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
pulkit updated this revision to Diff 2789.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1074?vs=2736=2789
REVISION DETAIL
https://phab.mercurial-scm.org/D1074
AFFECTED FILES
mercurial/cmdutil.py
mercurial/commands.py
tests/test-branch-change.t
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This patch utilises the functionality added in previous patches and adds a
flag
to amend command in hgext/amend to add a note to the amend. Since the note is
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
`commit --amend` and amend command in core and extensions rely on
cmdutil.amend() for amending a commit. So the logic to add a note to amend
must
reside here.
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This patch adds a metadata argument to cleanupnodes() which will be dict and
can
be passed to obsmarker.createmarkers() and can be stored on the obsmarker.
In
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1098
AFFECTED FILES
hgext/releasenotes.py
CHANGE DETAILS
diff --git a/hgext/releasenotes.py
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
While producing releasenotes for (4.3::), releasenotes aborts with error
because
of some bad formatting of releasenotes in some commits. Instead of aborting,
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
If fuzzywuzzy is note present, we will not be having the capability to merge
existing releasenotes with the new releasenotes on the similarity basis.
The merging
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1101
AFFECTED FILES
mercurial/wireproto.py
CHANGE DETAILS
diff --git a/mercurial/wireproto.py
durin42 updated this revision to Diff 2790.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1092?vs=2782=2790
REVISION DETAIL
https://phab.mercurial-scm.org/D1092
AFFECTED FILES
mercurial/peer.py
CHANGE DETAILS
diff --git a/mercurial/peer.py
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1103
AFFECTED FILES
mercurial/httppeer.py
CHANGE DETAILS
diff --git a/mercurial/httppeer.py
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1104
AFFECTED FILES
mercurial/peer.py
CHANGE DETAILS
diff --git a/mercurial/peer.py
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The latter returns a generator object on Python 3, which breaks
various parts of hg that expected a list.
REPOSITORY
rHG Mercurial
REVISION DETAIL
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
In Python 3, the map() returns a generator object instead of a list,
and some parts of hg depend on this being consumable more than once or
sortable in place.
phillco created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The worker processes can't share memory, so workers should not be used.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1105
phillco created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
With in-memory merge, copy information needs to be stored in-memory, not in
the
dirstate.
To make this transition easy, move the existing dirstate-based
phillco added inline comments.
INLINE COMMENTS
> durin42 wrote in filemerge.py:604
> Well that's a bummer. Could we move context.*filectx* into
> mercurial.filecontext and then avoid the need for this function-level import?
I don't think so, because the filectx classes reference the ctx
29 matches
Mail list logo