D1270: help: adding a topic on flags

rdamazio marked 4 inline comments as done. rdamazio added inline comments. INLINE COMMENTS > martinvonz wrote in flags.txt:67 > Do we recommend overriding the command like this or should the left side be > called something else (maybe "icommit")? I really don't know what we > recommend here,

D1336: HG: hg rm -A option prints the message of every file in the repo

mitrandir added a comment. @mharbison72: the problem is that `hg rm -A` prints a line for every file in the repo even if you didn't touch anything. With a clean working directory in a repo with 10k files, 10k lines will be printed. The lines look like: not removing : file still exists

D1270: help: adding a topic on flags

rdamazio updated this revision to Diff 3359. rdamazio marked 4 inline comments as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1270?vs=3334=3359 REVISION DETAIL https://phab.mercurial-scm.org/D1270 AFFECTED FILES contrib/wix/help.wxs

D1324: py3: handle keyword arguments in hgext/shelve.py

This revision was automatically updated to reflect the committed changes. Closed by commit rHGaad6b9fdfc75: py3: handle keyword arguments in hgext/shelve.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1320: py3: handle keyword arguments in hgext/keyword.py

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3fbc30f7b9f0: py3: handle keyword arguments in hgext/keyword.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1322: py3: handle keyword arguments in hgext/releasenotes.py

This revision was automatically updated to reflect the committed changes. Closed by commit rHGe68dd1909af3: py3: handle keyword arguments in hgext/releasenotes.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1318: py3: handle keyword arguments in hgext/histedit.py

This revision was automatically updated to reflect the committed changes. Closed by commit rHGc4b769bc86da: py3: handle keyword arguments in hgext/histedit.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1323: py3: handle keyword arguments in hgext/uncommit.py

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3ebae3ec4664: py3: handle keyword arguments in hgext/uncommit.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1321: py3: handle keyword arguments in hgext/rebase.py

This revision was automatically updated to reflect the committed changes. Closed by commit rHG1a07f9187831: py3: handle keyword arguments in hgext/rebase.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1331: cat: test output path behvaior when target path does not exist

This revision was automatically updated to reflect the committed changes. Closed by commit rHG8154119ed236: cat: test output path behvaior when target path does not exist (authored by ryanmce, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1332: cmdutil: create dirs for templated cat file output

This revision was automatically updated to reflect the committed changes. Closed by commit rHG407ec7f3ff02: cmdutil: create dirs for templated cat file output (authored by ryanmce, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D974: py3: handle keyword arguments correctly in hgext/patchbomb.py

pulkit updated this revision to Diff 3376. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D974?vs=3231=3376 REVISION DETAIL https://phab.mercurial-scm.org/D974 AFFECTED FILES hgext/patchbomb.py CHANGE DETAILS diff --git a/hgext/patchbomb.py

Re: [PATCH] debuglocks: allow setting a lock

On Wed, 08 Nov 2017 21:16:55 +0100, Paul Morelle wrote: > # HG changeset patch > # User Paul Morelle > # Date 1510071568 -3600 > # Tue Nov 07 17:19:28 2017 +0100 > # Node ID 5300b33397d0651eb2457502204969585d492cc5 > # Parent

D1316: py3: handle keyword arguments in hgext/graphlog.py

This revision was automatically updated to reflect the committed changes. Closed by commit rHG0c9ba2ac60a8: py3: handle keyword arguments in hgext/graphlog.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1317: py3: handle keyword arguments in hgext/hgk.py

This revision was automatically updated to reflect the committed changes. Closed by commit rHGfc0e6d298cd4: py3: handle keyword arguments in hgext/hgk.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1317?vs=3280=3361

D1311: scmutil: don't try to delete origbackup symlinks to directories (issue5731)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG99ab7bc944d2: scmutil: dont try to delete origbackup symlinks to directories (issue5731) (authored by mbthomas, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1310: tests: add a test demonstrating issue5731

This revision was automatically updated to reflect the committed changes. Closed by commit rHGad671b4cb9fc: tests: add a test demonstrating issue5731 (authored by mbthomas, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1310?vs=3264=3369

mercurial@35007: 11 new changesets

11 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/0c9ba2ac60a8 changeset: 34997:0c9ba2ac60a8 user:Pulkit Goyal <7895pul...@gmail.com> date:Mon Oct 23 00:03:08 2017 +0530 summary: py3: handle keyword arguments in hgext/graphlog.py

D1047: tweakdefaults: add restack command

quark abandoned this revision. quark added a comment. This does not belong to tweakdefaults, which is for BC purpose. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1047 To: quark, #hg-reviewers Cc: durin42, martinvonz, lothiraldan, dlax, mercurial-devel

D1063: rebase: enable multidest by default

quark requested review of this revision. quark added a comment. Since the freeze is over. I'd like to know how to move forward. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1063 To: quark, #hg-reviewers, durin42 Cc: dlax, martinvonz, durin42, mercurial-devel

D1285: localrepo: add a new attribute _visibilityexceptions and related API

quark added a comment. I think `localrepo` object is usually for unfiltered access therefore the visibility exception API looks strange to me. INLINE COMMENTS > localrepo.py:516 > +def addvisibilityexceptions(self, exceptions): > +""" adds hidden revs which should be visible to

D1063: rebase: enable multidest by default

martinvonz added a comment. In https://phab.mercurial-scm.org/D1063#22439, @quark wrote: > Since the freeze is over. I'd like to know how to move forward. Does that mean FB has now rewritten "hg restack" to use multi-destination rebase and used that in production for a while?

D1345: dirstate: add explicit methods for querying directories

mbolin added inline comments. INLINE COMMENTS > dirstate.py:393 > scmutil.checkfilename(f) > -if f in self._map.dirs: > +if self._map.hastrackeddir(f): > raise error.Abort(_('directory %r already in dirstate') % f) Can you just use `hasdir`

D1354: dirstate: change all writes to dirstatemap._map to go through one method.

mbolin created this revision. mbolin added reviewers: mbthomas, durham. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This separates some concerns that were introduced in https://phab.mercurial-scm.org/D1341. In particular, this makes

D1340: dirstate: add explicit methods for modifying dirstate

mbolin added inline comments. INLINE COMMENTS > dirstate.py:1275 > +""" > +exists = f in self._map > +if exists: To avoid doing two lookups in `self._map`: try: self._map.pop(f) return True except KeyError: return False REPOSITORY rHG Mercurial

D1341: dirstate: move management of nonnormal sets into dirstate map

mbolin added inline comments. INLINE COMMENTS > dirstate.py:1247 > self._map[f] = dirstatetuple(state, mode, size, mtime) > +if state != 'n' or mtime == -1: > +self.nonnormalset.add(f) I would prefer to see all mutations to `self._map` go through a common code path

D1351: changegroup: use any node, not min(), in treemanifest's generatemanifests

indygreg added a comment. Should I be concerned about the lack of test fallout? This new behavior is non-deterministic. Do we not have testing for this code or is existing testing not low-level enough to uncover behavior changes resulting from this change? INLINE COMMENTS >

D1329: bundle: allow bundlerepo to support alternative manifest implementations

indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. bundlerepo is a pile of hacks and this seems par for the course. FWIW, I've been looking at rewriting bundle2's I/O layer in order to address issue 5691. If you anticipate making

D1329: bundle: allow bundlerepo to support alternative manifest implementations

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa2dfc723b6b5: bundle: allow bundlerepo to support alternative manifest implementations (authored by durham, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1351: changegroup: use any node, not min(), in treemanifest's generatemanifests

martinvonz added a comment. In https://phab.mercurial-scm.org/D1351#22473, @indygreg wrote: > Should I be concerned about the lack of test fallout? This new behavior is non-deterministic. Do we not have testing for this code or is existing testing not low-level enough to uncover

D1351: changegroup: use any node, not min(), in treemanifest's generatemanifests

spectral added inline comments. INLINE COMMENTS > indygreg wrote in changegroup.py:738 > Can we use ``dict.popitem()`` instead? That will pop a random key-value pair. > I just don't know if the key needs to remain in the dict until later in the > function... I think that it needs to remain,

D1351: changegroup: use any node, not min(), in treemanifest's generatemanifests

martinvonz added inline comments. INLINE COMMENTS > spectral wrote in changegroup.py:738 > I think that it needs to remain, makelookupmflinknode(dir) relies on it > (L716). I haven't attempted to popitem and pass that to makelookupmflinknode > instead, let me try that out now... Oh, yuck.

D1351: changegroup: use any node, not min(), in treemanifest's generatemanifests

spectral updated this revision to Diff 3388. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1351?vs=3358=3388 REVISION DETAIL https://phab.mercurial-scm.org/D1351 AFFECTED FILES mercurial/changegroup.py CHANGE DETAILS diff --git

Re: [PATCH] debugdeltachain: output information about sparse read if enabled

On Wed, 08 Nov 2017 21:12:57 +0100, Paul Morelle wrote: > # HG changeset patch > # User Paul Morelle > # Date 1509002829 -7200 > # Thu Oct 26 09:27:09 2017 +0200 > # Node ID 13a6c881be35e7651a12f8c3442abfade2b77c88 > # Parent

D1351: changegroup: use any node, not min(), in treemanifest's generatemanifests

spectral marked 4 inline comments as done. spectral added a comment. run-tests.py found no issues with this version, my manual testing (using PYTHONHASHSEED to adjust the ordering) also encountered no issues INLINE COMMENTS > indygreg wrote in changegroup.py:738 > Can we use

D1336: HG: hg rm -A option prints the message of every file in the repo

mharbison72 added a comment. @mitrandir Oh, sorry, I see what you mean now. I wonder if the nice thing for people used to the current behavior is to terse the directories that don't have deleted files. That way the message is still there, but the sheer volume is lower. If an entire

D1337: util: add util.clearcachedproperty

indygreg accepted this revision. indygreg added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > util.py:936-937 > +'''clear a cached property value, if one has been set''' > +if prop in obj.__dict__: > +del obj.__dict__[prop] > + This pattern

D1339: dirstate: don't remove normallookup files from nonnormalset

indygreg added a comment. I was going to review this series. But I fear my dirstate knowledge is not good enough to understand the implications of all the changes. So I don't plan to look at it unless another reviewer can't be found. REPOSITORY rHG Mercurial REVISION DETAIL

D1351: changegroup: use any node, not min(), in treemanifest's generatemanifests

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd80380ba8e7d: changegroup: use any node, not min(), in treemanifests generatemanifests (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE